Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Adding compatibility for Angular 8 #1690

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,527 changes: 1,366 additions & 161 deletions package-lock.json

Large diffs are not rendered by default.

30 changes: 12 additions & 18 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,23 +66,17 @@
},
"homepage": "https://github.com/swimlane/ngx-datatable#readme",
"peerDependencies": {
"@angular/common": "<8.0.0",
"@angular/compiler": "<8.0.0",
"@angular/core": "<8.0.0",
"@angular/platform-browser": "<8.0.0",
"@angular/platform-browser-dynamic": "<8.0.0",
"core-js": "^2.5.0",
"rxjs": "^6.0.0"
"core-js": "^2.5.0"
},
"devDependencies": {
"@angular/animations": "^7.0.0",
"@angular/common": "^7.0.0",
"@angular/compiler": "^7.0.0",
"@angular/compiler-cli": "^7.0.0",
"@angular/core": "^7.0.0",
"@angular/platform-browser": "^7.0.0",
"@angular/platform-browser-dynamic": "^7.0.0",
"@angular/platform-server": "^7.0.0",
"@angular/animations": "^8.0.0-rc.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angular 8 just came out -- perhaps bump these to `"^8.0.0" ? 🙂

"@angular/common": "^8.0.0-rc.3",
"@angular/compiler": "^8.0.0-rc.3",
"@angular/compiler-cli": "^8.0.0-rc.3",
"@angular/core": "^8.0.0-rc.3",
"@angular/platform-browser": "^8.0.0-rc.3",
"@angular/platform-browser-dynamic": "^8.0.0-rc.3",
"@angular/platform-server": "^8.0.0-rc.3",
"@types/jasmine": "^2.8.4",
"@types/node": "^8.0.53",
"angular2-template-loader": "^0.6.2",
Expand Down Expand Up @@ -118,7 +112,7 @@
"puppeteer": "^1.0.0",
"replace": "^1.0.0",
"rimraf": "^2.6.2",
"rxjs": "~6.3.3",
"rxjs": "~6.5.2",
"sass-loader": "^6.0.6",
"source-map-loader": "^0.2.3",
"style-loader": "^0.19.0",
Expand All @@ -128,14 +122,14 @@
"tslint": "^5.8.0",
"tslint-config-swimlane": "^3.0.3",
"tslint-loader": "^3.5.3",
"typescript": "~3.1.0",
"typescript": "~3.4.5",
"uglify-js": "^3.1.10",
"url-loader": "^0.6.2",
"webpack": "^3.8.1",
"webpack-combine-loaders": "^2.0.3",
"webpack-dev-server": "^2.9.2",
"webpack-merge": "^4.1.1",
"webpack-notifier": "^1.5.0",
"zone.js": "^0.8.26"
"zone.js": "^0.9.1"
}
}
2 changes: 1 addition & 1 deletion release/components/body/body-cell.component.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion release/components/body/body-cell.component.metadata.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
[{"__symbolic":"module","version":4,"metadata":{"TreeStatus":{"__symbolic":"interface"},"DataTableBodyCellComponent":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Component","line":14,"character":1},"arguments":[{"selector":"datatable-body-cell","changeDetection":{"__symbolic":"select","expression":{"__symbolic":"reference","module":"@angular/core","name":"ChangeDetectionStrategy","line":16,"character":19},"member":"OnPush"},"template":"\n <div class=\"datatable-body-cell-label\"\n [style.margin-left.px]=\"calcLeftMargin(column, row)\">\n <label\n *ngIf=\"column.checkboxable && (!displayCheck || displayCheck(row, column, value))\"\n class=\"datatable-checkbox\">\n <input\n type=\"checkbox\"\n [checked]=\"isSelected\"\n (click)=\"onCheckboxChange($event)\"\n />\n </label>\n <ng-container *ngIf=\"column.isTreeColumn\">\n <button *ngIf=\"!column.treeToggleTemplate\"\n class=\"datatable-tree-button\"\n [disabled]=\"treeStatus==='disabled'\"\n (click)=\"onTreeAction()\">\n <span>\n <i *ngIf=\"treeStatus==='loading'\"\n class=\"icon datatable-icon-collapse\"></i>\n <i *ngIf=\"treeStatus==='collapsed'\"\n class=\"icon datatable-icon-up\"></i>\n <i *ngIf=\"treeStatus==='expanded' ||\n treeStatus==='disabled'\"\n class=\"icon datatable-icon-down\"></i>\n </span>\n </button>\n <ng-template *ngIf=\"column.treeToggleTemplate\"\n [ngTemplateOutlet]=\"column.treeToggleTemplate\"\n [ngTemplateOutletContext]=\"{ cellContext: cellContext }\">\n </ng-template>\n </ng-container>\n\n <span\n *ngIf=\"!column.cellTemplate\"\n [title]=\"sanitizedValue\"\n [innerHTML]=\"value\">\n </span>\n <ng-template #cellTemplate\n *ngIf=\"column.cellTemplate\"\n [ngTemplateOutlet]=\"column.cellTemplate\"\n [ngTemplateOutletContext]=\"cellContext\">\n </ng-template>\n </div>\n "}]}],"members":{"displayCheck":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":64,"character":3}}]}],"group":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":66,"character":3}}]}],"rowHeight":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":77,"character":3}}]}],"isSelected":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":88,"character":3}}]}],"expanded":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":98,"character":3}}]}],"rowIndex":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":108,"character":3}}]}],"column":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":119,"character":3}}]}],"row":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":130,"character":3}}]}],"sorts":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":141,"character":3}}]}],"treeStatus":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":150,"character":3}}]}],"activate":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Output","line":168,"character":3}}]}],"treeAction":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Output","line":170,"character":3}}]}],"cellTemplate":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"ViewChild","line":172,"character":3},"arguments":["cellTemplate",{"read":{"__symbolic":"reference","module":"@angular/core","name":"ViewContainerRef","line":172,"character":37}}]}]}],"columnCssClasses":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostBinding","line":174,"character":3},"arguments":["class"]}]}],"width":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostBinding","line":207,"character":3},"arguments":["style.width.px"]}]}],"minWidth":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostBinding","line":212,"character":3},"arguments":["style.minWidth.px"]}]}],"maxWidth":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostBinding","line":217,"character":3},"arguments":["style.maxWidth.px"]}]}],"height":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostBinding","line":222,"character":3},"arguments":["style.height"]}]}],"__ctor__":[{"__symbolic":"constructor","parameters":[{"__symbolic":"reference","module":"@angular/core","name":"ElementRef","line":261,"character":23},{"__symbolic":"reference","module":"@angular/core","name":"ChangeDetectorRef","line":261,"character":47}]}],"ngDoCheck":[{"__symbolic":"method"}],"ngOnDestroy":[{"__symbolic":"method"}],"checkValueUpdates":[{"__symbolic":"method"}],"onFocus":[{"__symbolic":"method","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostListener","line":299,"character":3},"arguments":["focus"]}]}],"onBlur":[{"__symbolic":"method","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostListener","line":304,"character":3},"arguments":["blur"]}]}],"onClick":[{"__symbolic":"method","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostListener","line":309,"character":3},"arguments":["click",["$event"]]}]}],"onDblClick":[{"__symbolic":"method","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostListener","line":323,"character":3},"arguments":["dblclick",["$event"]]}]}],"onKeyDown":[{"__symbolic":"method","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostListener","line":337,"character":3},"arguments":["keydown",["$event"]]}]}],"onCheckboxChange":[{"__symbolic":"method"}],"calcSortDir":[{"__symbolic":"method"}],"stripHtml":[{"__symbolic":"method"}],"onTreeAction":[{"__symbolic":"method"}],"calcLeftMargin":[{"__symbolic":"method"}]}}}}]
[{"__symbolic":"module","version":4,"metadata":{"TreeStatus":{"__symbolic":"interface"},"DataTableBodyCellComponent":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Component","line":13,"character":1},"arguments":[{"selector":"datatable-body-cell","changeDetection":{"__symbolic":"select","expression":{"__symbolic":"reference","module":"@angular/core","name":"ChangeDetectionStrategy","line":15,"character":19},"member":"OnPush"},"template":"\n <div class=\"datatable-body-cell-label\"\n [style.margin-left.px]=\"calcLeftMargin(column, row)\">\n <label\n *ngIf=\"column.checkboxable && (!displayCheck || displayCheck(row, column, value))\"\n class=\"datatable-checkbox\">\n <input\n type=\"checkbox\"\n [checked]=\"isSelected\"\n (click)=\"onCheckboxChange($event)\"\n />\n </label>\n <ng-container *ngIf=\"column.isTreeColumn\">\n <button *ngIf=\"!column.treeToggleTemplate\"\n class=\"datatable-tree-button\"\n [disabled]=\"treeStatus==='disabled'\"\n (click)=\"onTreeAction()\">\n <span>\n <i *ngIf=\"treeStatus==='loading'\"\n class=\"icon datatable-icon-collapse\"></i>\n <i *ngIf=\"treeStatus==='collapsed'\"\n class=\"icon datatable-icon-up\"></i>\n <i *ngIf=\"treeStatus==='expanded' ||\n treeStatus==='disabled'\"\n class=\"icon datatable-icon-down\"></i>\n </span>\n </button>\n <ng-template *ngIf=\"column.treeToggleTemplate\"\n [ngTemplateOutlet]=\"column.treeToggleTemplate\"\n [ngTemplateOutletContext]=\"{ cellContext: cellContext }\">\n </ng-template>\n </ng-container>\n\n <span\n *ngIf=\"!column.cellTemplate\"\n [title]=\"sanitizedValue\"\n [innerHTML]=\"value\">\n </span>\n <ng-template #cellTemplate\n *ngIf=\"column.cellTemplate\"\n [ngTemplateOutlet]=\"column.cellTemplate\"\n [ngTemplateOutletContext]=\"cellContext\">\n </ng-template>\n </div>\n "}]}],"members":{"displayCheck":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":63,"character":3}}]}],"group":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":65,"character":3}}]}],"rowHeight":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":76,"character":3}}]}],"isSelected":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":87,"character":3}}]}],"expanded":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":97,"character":3}}]}],"rowIndex":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":107,"character":3}}]}],"column":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":118,"character":3}}]}],"row":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":129,"character":3}}]}],"sorts":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":140,"character":3}}]}],"treeStatus":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":149,"character":3}}]}],"activate":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Output","line":167,"character":3}}]}],"treeAction":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Output","line":169,"character":3}}]}],"cellTemplate":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"ViewChild","line":171,"character":3},"arguments":["cellTemplate",{"read":{"__symbolic":"reference","module":"@angular/core","name":"ViewContainerRef","line":171,"character":37}}]}]}],"columnCssClasses":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostBinding","line":173,"character":3},"arguments":["class"]}]}],"width":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostBinding","line":206,"character":3},"arguments":["style.width.px"]}]}],"minWidth":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostBinding","line":211,"character":3},"arguments":["style.minWidth.px"]}]}],"maxWidth":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostBinding","line":216,"character":3},"arguments":["style.maxWidth.px"]}]}],"height":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostBinding","line":221,"character":3},"arguments":["style.height"]}]}],"__ctor__":[{"__symbolic":"constructor","parameters":[{"__symbolic":"reference","module":"@angular/core","name":"ElementRef","line":260,"character":23},{"__symbolic":"reference","module":"@angular/core","name":"ChangeDetectorRef","line":260,"character":47}]}],"ngDoCheck":[{"__symbolic":"method"}],"ngOnDestroy":[{"__symbolic":"method"}],"checkValueUpdates":[{"__symbolic":"method"}],"onFocus":[{"__symbolic":"method","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostListener","line":298,"character":3},"arguments":["focus"]}]}],"onBlur":[{"__symbolic":"method","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostListener","line":303,"character":3},"arguments":["blur"]}]}],"onClick":[{"__symbolic":"method","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostListener","line":308,"character":3},"arguments":["click",["$event"]]}]}],"onDblClick":[{"__symbolic":"method","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostListener","line":322,"character":3},"arguments":["dblclick",["$event"]]}]}],"onKeyDown":[{"__symbolic":"method","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"HostListener","line":336,"character":3},"arguments":["keydown",["$event"]]}]}],"onCheckboxChange":[{"__symbolic":"method"}],"calcSortDir":[{"__symbolic":"method"}],"stripHtml":[{"__symbolic":"method"}],"onTreeAction":[{"__symbolic":"method"}],"calcLeftMargin":[{"__symbolic":"method"}]}}}}]
3 changes: 2 additions & 1 deletion release/components/body/body.component.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading