-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to angular 8 #1697
Upgrade to angular 8 #1697
Conversation
Can confirm:
🚀 🎉 🙌 |
ps --
Running
Something to keep in mind for the future 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Cloned repository
- checked out
ng8
branch - ran
npm install
- ran
npm start
👌(got working app) - ran
npm test
👌(got no failing tests)
Everything seems to be working great 💯
@whyboris thanks for testing! Merging. Will release 15.0.0 shortly. |
Thank you @marjan-georgiev -- I pulled in your release and our production app is now fully working with Angular 8 🎉 🙇 🤝 |
Great to hear! |
Thank You @marjan-georgiev 🎉 |
Nice! just before release 🎉 |
Hello @marjan-georgiev I just noticed that the headerComponent of DatatableComponent is always undefined for the new version. What may be the problem? Thanks. |
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
fixes #1694
fixes: #1693
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: