Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to angular 8 #1697

Merged
merged 4 commits into from
May 29, 2019
Merged

Upgrade to angular 8 #1697

merged 4 commits into from
May 29, 2019

Conversation

marjan-georgiev
Copy link
Member

@marjan-georgiev marjan-georgiev commented May 29, 2019

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

fixes #1694
fixes: #1693

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

This was referenced May 29, 2019
@whyboris
Copy link
Contributor

Can confirm:

  • cloned the repository (clean copy)
  • checked out ng8 branch
  • ran npm install (no errors)
  • ran npm start -- was able to see the page with all the different types of datatable
  • ran npm test -- 126 SUCCESS (no failed, 3 skipped, 69.5% statement code coverage)

🚀 🎉 🙌

@whyboris
Copy link
Contributor

ps -- npm install gave this warning:

found 4 vulnerabilities (2 low, 1 moderate, 1 high)
  run `npm audit fix` to fix them, or `npm audit` for details

Running npm audit fix resulted in:

fixed 0 of 4 vulnerabilities in 15965 scanned packages
  1 vulnerability required manual review and could not be updated
  2 package updates for 3 vulns involved breaking changes

Something to keep in mind for the future 👌

Copy link
Contributor

@whyboris whyboris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Cloned repository
  • checked out ng8 branch
  • ran npm install
  • ran npm start 👌(got working app)
  • ran npm test 👌(got no failing tests)

Everything seems to be working great 💯

@marjan-georgiev
Copy link
Member Author

@whyboris thanks for testing!

Merging. Will release 15.0.0 shortly.

@marjan-georgiev marjan-georgiev merged commit a9898c4 into master May 29, 2019
@whyboris
Copy link
Contributor

Thank you @marjan-georgiev -- I pulled in your release and our production app is now fully working with Angular 8 🎉 🙇 🤝
Cheers!

@marjan-georgiev
Copy link
Member Author

Great to hear!

@TidianeChelsea
Copy link

Thank You @marjan-georgiev 🎉
All working GREAT.

@bleuscyther
Copy link

bleuscyther commented May 30, 2019

Nice! just before release 🎉

@TidianeChelsea
Copy link

Hello @marjan-georgiev

I just noticed that the headerComponent of DatatableComponent is always undefined for the new version.

What may be the problem?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants