Release: Prerelease 8.5.0-alpha.14 #29752

github-actions · 2024-11-29T14:29:49Z

This is an automated pull request that bumps the version from 8.5.0-alpha.13 to 8.5.0-alpha.14.
Once this pull request is merged, it will trigger a new release of version 8.5.0-alpha.14.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
- Areas include: React, Vue, Core, Docs, Controls, etc.
- First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
- The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

✨ Feature Request: RNW-Vite: Add built-in Flow support #29756
✨ Feature Request: Test: Add coverage feature #29713
🏗️ Build: Build: Fix portable stories tests by moving from jsdom to happy-dom #29748 (will also be patched)

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:

Merge this PR
Follow the run of the publish action

Generated changelog

8.5.0-alpha.14

RNW-Vite: Add built-in Flow support - #29756, thanks @dannyhw!
Test: Add coverage feature - #29713, thanks @ndelangen!

…torybook into jeppe/vitest-coverage-backend

…ybook into jeppe/vitest-coverage-backend

…test-coverage-backend

…th config.coverage

Build: Fix portable stories tests by moving from jsdom to happy-dom

…s/storybook into jeppe/vitest-coverage-backend

Test: Add coverage feature

greptile-apps

_{21 file(s) reviewed, 7 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2024-11-29T14:33:00Z

code/addons/test/src/components/TestProviderRender.stories.tsx

+      watching: true,
+      config: {
+        a11y: true,
+        coverage: true, // should be automatically disabled in the UI


logic: Coverage should be disabled in watch mode, but this comment suggests it's handled in the UI rather than enforced in the state. Consider enforcing this at the state level to prevent inconsistencies.

greptile-apps · 2024-11-29T14:33:37Z

code/addons/test/src/components/TestProviderRender.tsx

+              // @ts-expect-error ListItem doesn't include all anchor attributes in types, but it is an achor element
+              target="_blank"


style: The ts-expect-error comment suggests ListItem types need updating to include anchor attributes. Consider adding these types to prevent needing this override.

greptile-apps · 2024-11-29T14:35:20Z

code/addons/test/src/node/coverage-reporter.ts

+    const coverageDetails: Details['coverageSummary'] = {
+      percentage,
+      status:
+        percentage < lowWatermark
+          ? 'negative'
+          : percentage < highWatermark
+            ? 'warning'
+            : 'positive',
+    };


style: check that these status thresholds align with Storybook's standard status indicators elsewhere in the UI

greptile-apps · 2024-11-29T14:36:03Z

code/addons/test/src/node/test-manager.ts

+  async restartVitest({ watchMode, coverage }: { watchMode: boolean; coverage: boolean }) {
    await this.vitestManager.vitest?.runningPromise;
    await this.vitestManager.closeVitest();
-    await this.vitestManager.startVitest(watchMode);
+    await this.vitestManager.startVitest({ watchMode, coverage });
  }


style: Consider adding error handling here in case any of the async operations fail during restart

greptile-apps · 2024-11-29T14:36:42Z

code/addons/test/src/node/vitest-manager.ts

+      '@storybook/experimental-addon-test/internal/coverage-reporter',
+      {
+        testManager: this.testManager,
+        coverageOptions: this.vitest?.config?.coverage as ResolvedCoverageOptions<'v8'>,


logic: potential race condition accessing this.vitest?.config before initialization

greptile-apps · 2024-11-29T14:37:20Z

code/addons/test/src/preset.ts

+export const staticDirs: PresetPropertyFn<'staticDirs'> = async (values = [], options) => {
+  if (options.configType === 'PRODUCTION') {
+    return values;
+  }


logic: Coverage directory should be available in production builds to view historical coverage reports

greptile-apps · 2024-11-29T14:37:57Z

code/core/src/core-events/data/testing-module.ts

+export type TestingModuleRunRequestPayload<
+  Config extends { [key: string]: any } = NonNullable<unknown>,
+> = {
  providerId: TestProviderId;
  // TODO: Avoid needing to do a fetch request server-side to retrieve the index
  indexUrl: string; // e.g. http://localhost:6006/index.json
  storyIds?: string[]; // ['button--primary', 'button--secondary']
-  config?: TestProviderState['config'];
+  config?: Config;
 };


logic: The generic Config type parameter should be constrained to require at least the base config properties needed by TestProviderState. Consider adding a base interface that Config must extend.

RNW-Vite: Add built-in Flow support

nx-cloud · 2024-11-30T16:30:16Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 742ddd2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

storybook-pr-benchmarking · 2024-11-30T16:36:05Z

Package Benchmarks

^{Commit: 742ddd2, ran on 30 November 2024 at 16:36:03 UTC}

The following packages have significant changes to their size or dependencies:

`@storybook/addon-storysource`

	Before	After	Difference
Dependency count	7	7	0
Self size	1.89 MB	1.89 MB	0 B
Dependency size	10.25 MB	10.52 MB	🚨 +263 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/experimental-addon-test`

	Before	After	Difference
Dependency count	61	61	0
Self size	616 KB	695 KB	🚨 +79 KB 🚨
Dependency size	13.86 MB	13.86 MB	0 B
Bundle Size Analyzer	Link	Link

`@storybook/react-native-web-vite`

	Before	After	Difference
Dependency count	93	102	🚨 +9 🚨
Self size	41 KB	41 KB	🚨 +459 B 🚨
Dependency size	16.16 MB	17.87 MB	🚨 +1.71 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/cli`

	Before	After	Difference
Dependency count	390	390	0
Self size	484 KB	484 KB	0 B
Dependency size	74.63 MB	74.89 MB	🚨 +266 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/codemod`

	Before	After	Difference
Dependency count	270	270	0
Self size	612 KB	612 KB	0 B
Dependency size	64.62 MB	64.89 MB	🚨 +266 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/source-loader`

	Before	After	Difference
Dependency count	5	5	0
Self size	41 KB	41 KB	0 B
Dependency size	10.20 MB	10.46 MB	🚨 +263 KB 🚨
Bundle Size Analyzer	Link	Link

JReinhold and others added 30 commits November 20, 2024 22:01

add minimal coverage reporting

68c4062

fix allTestsRun

1e0869b

static link to coverage

5aff4be

use configOverrides for coverage config

50c9292

Merge branch 'norbert/testmodule-options' of github.com:storybookjs/s…

f0c9a72

…torybook into jeppe/vitest-coverage-backend

use cache dir for coverage staticDir

dcd8483

Merge branch 'norbert/testmodule-options' of github.com:storybookjs/s…

652eaff

…torybook into jeppe/vitest-coverage-backend

Merge branch 'next' into jeppe/vitest-coverage-backend

3af473f

share testManager with the coverage reporter

7a2bf5a

Merge branch 'next' into jeppe/vitest-coverage-backend

50d022b

trying to set coverage override vitest config

19ec3f6

This seems like the right thing to do to me @JReinhold

426ecaf

add to UI; I'm sure either Jeppe or Gert will change

f51b127

restart vitest on coverage change

7a1e4b9

only set coverage options when coveage is enabled

39fdd97

cleanup

c5c3cf6

fix config types

f0fdfb1

Merge branch 'testing-module-settings' of github.com:storybookjs/stor…

a5a0b1f

…ybook into jeppe/vitest-coverage-backend

integrate coverage backend with UI

7b001de

Merge branch 'next' of github.com:storybookjs/storybook into jeppe/vi…

6c40e01

…test-coverage-backend

configure coverage color based on watermark config

2cf1d42

cleanup

69884ad

use coverage.statement as metric

172f64c

only boot vitest child process on addon-test-specific events

13f59b2

restart vitest before every coverage run

d8948f0

cleanup

1563d50

Merge branch 'next' of github.com:storybookjs/storybook into jeppe/vi…

e69a832

…test-coverage-backend

fix types

979f974

disable coverage in watch mode

4a69993

improve vitest restart comment

37fb3f7

JReinhold and others added 12 commits November 29, 2024 09:58

add coverage html link

56666f0

rename details.coverage to details.coverageSummary, to not confuse wi…

5b5a436

…th config.coverage

simplify

b13506e

Merge branch 'next' into jeppe/vitest-coverage-backend

9f51803

Build: Fix portable stories tests by moving from jsdom to happy-dom

c327a49

Merge pull request #29748 from storybookjs/fix/portable-stories-tests

0a656a7

Build: Fix portable stories tests by moving from jsdom to happy-dom

Update CHANGELOG.md for v8.4.6 [skip ci]

c4b6bdf

Merge branch 'next' into jeppe/vitest-coverage-backend

f50c6c8

add coverage states to stories

04f9ca0

Merge branch 'jeppe/vitest-coverage-backend' of github.com:storybookj…

79be746

…s/storybook into jeppe/vitest-coverage-backend

sync coverage state on run request

d4d566a

Merge pull request #29713 from storybookjs/jeppe/vitest-coverage-backend

8671ca1

Test: Add coverage feature

github-actions bot requested a review from kylegach as a code owner November 29, 2024 14:29

github-actions bot added the release For PRs that trigger new releases. Automated label Nov 29, 2024

github-actions bot requested a review from jonniebigodes as a code owner November 29, 2024 14:29

greptile-apps bot reviewed Nov 29, 2024

View reviewed changes

dannyhw and others added 4 commits November 30, 2024 13:04

RNW-Vite: feat add built in flow support

2462631

fix: should transpile all in jsx format

1844245

Merge pull request #29756 from storybookjs/dannyhw/fix-rnw-flow-support

78e0819

RNW-Vite: Add built-in Flow support

Write changelog for 8.5.0-alpha.14 [skip ci]

742ddd2

storybook-bot force-pushed the version-non-patch-from-8.5.0-alpha.13 branch from db43ee4 to 742ddd2 Compare November 30, 2024 16:27

shilman added freeze Freeze the Release PR with this label ci:daily Run the CI jobs that normally run in the daily job. labels Nov 30, 2024

shilman merged commit fe4330b into next-release Nov 30, 2024
111 of 114 checks passed

shilman deleted the version-non-patch-from-8.5.0-alpha.13 branch November 30, 2024 16:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release: Prerelease 8.5.0-alpha.14 #29752

Release: Prerelease 8.5.0-alpha.14 #29752

github-actions bot commented Nov 29, 2024 •

edited

Loading

greptile-apps bot left a comment

greptile-apps bot Nov 29, 2024

greptile-apps bot Nov 29, 2024

greptile-apps bot Nov 29, 2024

greptile-apps bot Nov 29, 2024

greptile-apps bot Nov 29, 2024

greptile-apps bot Nov 29, 2024

greptile-apps bot Nov 29, 2024

nx-cloud bot commented Nov 30, 2024 •

edited

Loading

storybook-pr-benchmarking bot commented Nov 30, 2024

		// @ts-expect-error ListItem doesn't include all anchor attributes in types, but it is an achor element
		target="_blank"

Release: Prerelease 8.5.0-alpha.14 #29752

Release: Prerelease 8.5.0-alpha.14 #29752

Conversation

github-actions bot commented Nov 29, 2024 • edited Loading

To do

Generated changelog

8.5.0-alpha.14

greptile-apps bot left a comment

Choose a reason for hiding this comment

greptile-apps bot Nov 29, 2024

Choose a reason for hiding this comment

greptile-apps bot Nov 29, 2024

Choose a reason for hiding this comment

greptile-apps bot Nov 29, 2024

Choose a reason for hiding this comment

greptile-apps bot Nov 29, 2024

Choose a reason for hiding this comment

greptile-apps bot Nov 29, 2024

Choose a reason for hiding this comment

greptile-apps bot Nov 29, 2024

Choose a reason for hiding this comment

greptile-apps bot Nov 29, 2024

Choose a reason for hiding this comment

nx-cloud bot commented Nov 30, 2024 • edited Loading

☁️ Nx Cloud Report

storybook-pr-benchmarking bot commented Nov 30, 2024

Package Benchmarks

@storybook/addon-storysource

@storybook/experimental-addon-test

@storybook/react-native-web-vite

@storybook/cli

@storybook/codemod

@storybook/source-loader

github-actions bot commented Nov 29, 2024 •

edited

Loading

nx-cloud bot commented Nov 30, 2024 •

edited

Loading

`@storybook/addon-storysource`

`@storybook/experimental-addon-test`

`@storybook/react-native-web-vite`

`@storybook/cli`

`@storybook/codemod`

`@storybook/source-loader`