RNW-Vite: Add built-in Flow support #29756
Conversation
shilman
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| flowPlugin({ | ||
| exclude: [], | ||
| }), |
There was a problem hiding this comment.
style: Empty exclude array may cause Flow to process all files. Consider adding appropriate exclusions for node_modules and build artifacts
dannyhw
force-pushed
the
dannyhw/fix-rnw-flow-support
branch
from
54a9fee to
2462631
Compare
There was a problem hiding this comment.
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -1,8 +1,9 @@ | |||
| // @ts-expect-error FIXME | |||
There was a problem hiding this comment.
style: Fix the underlying type error instead of using @ts-expect-error
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1844245. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 7 | 7 | 0 |
| Self size | 1.89 MB | 1.89 MB | 0 B |
| Dependency size | 10.25 MB | 10.52 MB | 🚨 +263 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 93 | 102 | 🚨 +9 🚨 |
| Self size | 41 KB | 41 KB | 🚨 +459 B 🚨 |
| Dependency size | 16.16 MB | 17.87 MB | 🚨 +1.71 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 390 | 390 | 0 |
| Self size | 484 KB | 484 KB | 0 B |
| Dependency size | 74.63 MB | 74.89 MB | 🚨 +265 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 270 | 270 | 0 |
| Self size | 612 KB | 612 KB | 0 B |
| Dependency size | 64.62 MB | 64.89 MB | 🚨 +265 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/source-loader
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 5 | 5 | 0 |
| Self size | 41 KB | 41 KB | 0 B |
| Dependency size | 10.20 MB | 10.46 MB | 🚨 +263 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
shilman
changed the title
shilman
changed the title
There was a problem hiding this comment.
132 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| return mergeConfig(reactConfig, { | ||
| optimizeDeps: { | ||
| esbuildOptions: { | ||
| plugins: [esbuildFlowPlugin(new RegExp(/\.(flow|jsx?)$/), (_path: string) => 'jsx')], |
There was a problem hiding this comment.
logic: Regular expression should be anchored with ^ and $ to prevent partial matches in file paths
There was a problem hiding this comment.
LGTM
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Closes #
What I did
Added support for flow which is used by some React Native libraries and React Native source code itself.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-29756-sha-18442450. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-29756-sha-18442450 sandboxor in an existing project withnpx storybook@0.0.0-pr-29756-sha-18442450 upgrade.More information
0.0.0-pr-29756-sha-18442450dannyhw/fix-rnw-flow-support184424501732974321)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=29756Greptile Summary
Added Flow support to React Native Web Vite framework in Storybook to handle Flow types used in React Native libraries and source code.
@bunchtogether/vite-plugin-flowdependency incode/frameworks/react-native-web-vite/package.jsoncode/frameworks/react-native-web-vite/src/preset.ts.flowand.jsxfilestypings.d.tsfor TypeScript compatibility💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!