-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Add coverage feature #29713
Test: Add coverage feature #29713
Conversation
…torybook into jeppe/vitest-coverage-backend
…torybook into jeppe/vitest-coverage-backend
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d4d566a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
Before | After | Difference | |
---|---|---|---|
Dependency count | 61 | 61 | 0 |
Self size | 616 KB | 695 KB | 🚨 +79 KB 🚨 |
Dependency size | 13.86 MB | 13.86 MB | 0 B |
Bundle Size Analyzer | Link | Link |
…ybook into jeppe/vitest-coverage-backend
…test-coverage-backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 14 changed files in this pull request and generated no suggestions.
Files not reviewed (8)
- code/addons/test/package.json: Language not supported
- code/addons/test/src/constants.ts: Evaluated as low risk
- code/addons/test/src/node/coverage-reporter.ts: Evaluated as low risk
- code/addons/test/src/node/test-manager.ts: Evaluated as low risk
- code/addons/test/src/node/vitest-manager.ts: Evaluated as low risk
- code/addons/test/src/node/vitest.ts: Evaluated as low risk
- code/addons/test/src/preset.ts: Evaluated as low risk
- code/core/src/core-events/data/testing-module.ts: Evaluated as low risk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
13 file(s) reviewed, 14 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…s/storybook into jeppe/vitest-coverage-backend
Works on #29530
What I did
Hooked up the coverage frontend to the Vitest backend, adding support for reporting coverage during test runs.
Todo
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
Added coverage reporting functionality to the Storybook test addon, integrating with Vitest to display test coverage metrics in the UI and generate HTML coverage reports.
StorybookCoverageReporter
class incode/addons/test/src/node/coverage-reporter.ts
to handle coverage metrics and reportingTestProviderRender.tsx
to display coverage percentage and status in the UI with proper state managementvitest-manager.ts
with HTML and Storybook reporter integrationpreset.ts
to make coverage reports accessible via browser💡 (5/5) You can turn off certain types of comments like style here!