Release: Prerelease 8.4.0-alpha.1 #29118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Unblocks loading Storybook instances built with Vite devices with pre-2022 browser versions. Resolves #29030
Addon-Interactions: Use ansi-to-html for colored test errors
github-actions
bot
requested review from
kylegach and
jonniebigodes
as code owners
github-actions
bot
added
the
release
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
9 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
| @@ -135,7 +136,7 @@ export const Exception = ({ exception }: { exception: Call['exception'] }) => { | |||
| const more = paragraphs.length > 1; | |||
| return ( | |||
| <RowMessage> | |||
| <pre>{paragraphs[0]}</pre> | |||
| <pre dangerouslySetInnerHTML={{ __html: filter.toHtml(paragraphs[0]) }}></pre> | |||
There was a problem hiding this comment.
style: Use of dangerouslySetInnerHTML could pose a security risk if the input is not properly sanitized
Comment on lines
+137
to
+139
| dangerouslySetInnerHTML={{ | ||
| __html: filter.toHtml(printSerializedError(caughtException)), | ||
| }} |
There was a problem hiding this comment.
style: Use of dangerouslySetInnerHTML might pose security risks if the input is not properly sanitized
Comment on lines
+137
to
+140
| <span | ||
| key={line + index} | ||
| dangerouslySetInnerHTML={{ __html: filter.toHtml(line) }} | ||
| ></span>, |
There was a problem hiding this comment.
logic: Using dangerouslySetInnerHTML can be a security risk if the input is not properly sanitized. Ensure that the filter.toHtml() method properly escapes any potentially malicious content.
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.0
branch
from
e8e2e90 to
f93f6ba
Compare
Addon Test: Support story name as test description
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.0
branch
from
f93f6ba to
99c7d58
Compare
Chore: Add jiti as dev dependency to core
CLI: Show constraints in error when getting depndencies
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.0
branch
from
99c7d58 to
3a93f6d
Compare
Vite: Add jsdoc-type-pratt-parser to `optimizeDeps`
Fix composed storybook TooltipLinkList bug where href isn't passed forward
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.0
branch
from
3a93f6d to
7914eb4
Compare
Add InitialViewportKeyUnion type to viewport addon
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.0
branch
from
7914eb4 to
bac063f
Compare
…ed-via-cli-ends-with-a-newline Ensure `.gitignore` updated via CLI ends with a newline
Builder-vite: Replace .at() call with [] in codegen
storybook-bot
force-pushed
the
version-non-patch-from-8.4.0-alpha.0
branch
from
bac063f to
02598e5
Compare
kasperpeulen
added
freeze
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 02598e5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.4.0-alpha.0to8.4.0-alpha.1.Once this pull request is merged, it will trigger a new release of version
8.4.0-alpha.1.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:.gitignoreupdated via CLI ends with a newline #29124optimizeDeps#29179storybook dev#29152 (will also be patched)fs-extrawith the native APIs #29126If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.4.0-alpha.1
.gitignoreupdated via CLI ends with a newline - #29124, thanks @3w36zj6!storybook dev- #29152, thanks @valentinpalkovic!fs-extrawith the native APIs - #29126, thanks @ziebam!optimizeDeps- #29179, thanks @tobiasdiez!