Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Upgrade sass-loader from ^12 to ^13 #29040

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

HoncharenkoZhenya
Copy link
Contributor

@HoncharenkoZhenya HoncharenkoZhenya commented Sep 3, 2024

Closes #

What I did

Update sass-loader version like in https://github.com/RyanClementsHax/storybook-addon-next/blob/main/package.json for compatibility with nodejs > 20

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.3 MB 77.3 MB 0 B 0.86 0%
initSize 162 MB 162 MB 0 B 1.03 0%
diffSize 85 MB 85 MB 0 B 1.14 0%
buildSize 7.58 MB 7.58 MB 0 B 2.86 0%
buildSbAddonsSize 1.67 MB 1.67 MB 0 B 4.36 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.34 MB 2.34 MB 0 B 0.5 0%
buildSbPreviewSize 352 kB 352 kB 0 B 1.73 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.55 MB 4.55 MB 0 B 3.05 0%
buildPreviewSize 3.02 MB 3.02 MB 0 B 1.63 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 14.8s 6.9s -7s -926ms -1.04 -113.9%
generateTime 19s 19.7s 683ms -0.79 3.5%
initTime 16.8s 18s 1.2s 0.6 6.9%
buildTime 13.4s 12.5s -853ms 0.33 -6.8%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 7.7s 7.3s -459ms 0.36 -6.3%
devManagerResponsive 4.8s 4.6s -262ms 0.27 -5.7%
devManagerHeaderVisible 866ms 858ms -8ms 0.43 -0.9%
devManagerIndexVisible 911ms 897ms -14ms 0.41 -1.6%
devStoryVisibleUncached 1.5s 1.4s -135ms -0.03 -9.6%
devStoryVisible 909ms 899ms -10ms 0.42 -1.1%
devAutodocsVisible 857ms 738ms -119ms 0.11 -16.1%
devMDXVisible 728ms 773ms 45ms 0.59 5.8%
buildManagerHeaderVisible 832ms 804ms -28ms 0.73 -3.5%
buildManagerIndexVisible 881ms 805ms -76ms 0.36 -9.4%
buildStoryVisible 880ms 847ms -33ms 0.53 -3.9%
buildAutodocsVisible 825ms 701ms -124ms -0.11 -17.7%
buildMDXVisible 735ms 719ms -16ms 0.6 -2.2%

Greptile Summary

Updated sass-loader version in NextJS framework for Node.js >20 compatibility.

  • Changed sass-loader from 12.4.0 to 13.2.0 in code/frameworks/nextjs/package.json
  • Improves compatibility with Node.js versions greater than 20
  • Minor update that may affect Sass build process in Next.js projects using Storybook

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Sep 3, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dac2cc3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic added bug nextjs ci:daily Run the CI jobs that normally run in the daily job. labels Sep 5, 2024
@valentinpalkovic valentinpalkovic self-assigned this Sep 5, 2024
@valentinpalkovic valentinpalkovic changed the title NextJS: fix sass-loader version for compatibility with nodejs > 20 NextJS: Upgrade sass-loader from ^12 to ^13 Sep 5, 2024
@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 5, 2024
@valentinpalkovic valentinpalkovic changed the title NextJS: Upgrade sass-loader from ^12 to ^13 Next.js: Upgrade sass-loader from ^12 to ^13 Sep 10, 2024
@valentinpalkovic valentinpalkovic merged commit 6019553 into storybookjs:next Sep 16, 2024
100 checks passed
storybook-bot pushed a commit that referenced this pull request Sep 16, 2024
Next.js: Upgrade sass-loader from ^12 to ^13

(cherry picked from commit 6019553)
storybook-bot pushed a commit that referenced this pull request Sep 16, 2024
Next.js: Upgrade sass-loader from ^12 to ^13

(cherry picked from commit 6019553)
storybook-bot pushed a commit that referenced this pull request Sep 16, 2024
Next.js: Upgrade sass-loader from ^12 to ^13

(cherry picked from commit 6019553)
storybook-bot pushed a commit that referenced this pull request Sep 16, 2024
Next.js: Upgrade sass-loader from ^12 to ^13

(cherry picked from commit 6019553)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job. nextjs patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants