-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React-Vite: Downgrade react-docgen-typescript plugin #29184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d5ba8e5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
…pescript-docgen React-Vite: Downgrade react-docgen-typescript plugin (cherry picked from commit b23e84a)
…pescript-docgen React-Vite: Downgrade react-docgen-typescript plugin (cherry picked from commit b23e84a)
…pescript-docgen React-Vite: Downgrade react-docgen-typescript plugin (cherry picked from commit b23e84a)
…pescript-docgen React-Vite: Downgrade react-docgen-typescript plugin (cherry picked from commit b23e84a)
…pescript-docgen React-Vite: Downgrade react-docgen-typescript plugin (cherry picked from commit b23e84a)
…pescript-docgen React-Vite: Downgrade react-docgen-typescript plugin (cherry picked from commit b23e84a)
…pescript-docgen React-Vite: Downgrade react-docgen-typescript plugin (cherry picked from commit b23e84a)
https://github.com/joshwooding/vite-plugin-react-docgen-typescript/releases/tag/%40joshwooding%2Fvite-plugin-react-docgen-typescript%400.4.1 is out which should fix this but it needs testing |
Closes #28269
What I did
Fix HMR performance issue by downgrading the react-docgen-typescript Vite plugin
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Upgrade repro in #28269 to canary (have not tested)
🦋 Canary release
This pull request has been released as version
0.0.0-pr-29184-sha-d5ba8e56
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-29184-sha-d5ba8e56 sandbox
or in an existing project withnpx storybook@0.0.0-pr-29184-sha-d5ba8e56 upgrade
.More information
0.0.0-pr-29184-sha-d5ba8e56
shilman/28269-downgrade-typescript-docgen
d5ba8e56
1727086101
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=29184
Greptile Summary
This pull request downgrades the @joshwooding/vite-plugin-react-docgen-typescript dependency to address a performance issue with Hot Module Replacement (HMR) in Storybook's React-Vite framework.
code/frameworks/react-vite/package.json
to downgrade @joshwooding/vite-plugin-react-docgen-typescript from 0.3.1 to 0.3.0react-docgen-typescript
sincev8.1.0
#28269 when using 'react-docgen-typescript'