Add scooter stop fallback message #767
Conversation
|
|
@hbruch Could you please define a condition for exactly when should we use the fallback message? The easiest case (which the original ticket mentioned) is when there is no |
|
Why not only show " station". Maybe we have to decide per network, if station.name is useful to display |
| <div className="selected-stop-header">{stop.name}</div> | ||
| <div className="selected-stop-header"> | ||
| {!stop.name || stop.networks[0] === 'tier_REUTLINGEN' ? ( | ||
| <FormattedMessage |
There was a problem hiding this comment.
We should not use network specific code here. Is there a way to deduce the vehicleType from the stop and use a vehicleType specific message?
There was a problem hiding this comment.
I used this solution because originally the popup should show the name of the actual stop - but in case of this network, the name is an incomprehensible number code. If we'd use any other condition, this process will change. Should we refactor this anyway and do not use the name (not at any stop popup) but display a message based on the vehicle type?
| @@ -19,6 +19,10 @@ BikeRentalStationPageMapContainer.propTypes = { | |||
| lat: PropTypes.number.isRequired, | |||
| lon: PropTypes.number.isRequired, | |||
| name: PropTypes.string, | |||
| networks: PropTypes.oneOfType([ | |||
| PropTypes.string, | |||
There was a problem hiding this comment.
When will networks be string, when array?
There was a problem hiding this comment.
It's always a string array. When it has only one element, it can be handled as a string.
Beck-berry
force-pushed
the
feat/scooter_stop_fallback_msg
branch
from
ae2cc89
to
4976661
Compare
|
Depending on #774. Needs refactoring after the merge of that. |
Proposed Changes
networkspropertystation.networksifstation.nameis not given or if the network istier-reutlingenPull Request Check List
Review
Closes #760