Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fallback for bike sharing popup when name is empty #760

Open
leonardehrenfried opened this issue Sep 8, 2021 · 0 comments · May be fixed by #767
Open

Use fallback for bike sharing popup when name is empty #760

leonardehrenfried opened this issue Sep 8, 2021 · 0 comments · May be fixed by #767

Comments

@leonardehrenfried
Copy link
Collaborator

leonardehrenfried commented Sep 8, 2021

When running with the following config:

 CONFIG=landstadtmobil API_URL=https://api.dev.stadtnavi.eu yarn run dev

you can see that the rental bikes (actually scooters) popups are empty:

Screenshot from 2021-09-08 12-42-56

This is because DT assumes that these are stations that have a name. These individual scooters have no names.

Acceptance criteria

When name is empty or empty string, then use the translation key {network}-station-no-id, which in the TIER Reutlingen case is just "TIER E-Scooter".

@Beck-berry Beck-berry linked a pull request Sep 11, 2021 that will close this issue
@Beck-berry Beck-berry removed their assignment Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants