Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize vehicle rental messages #774

Merged
merged 8 commits into from
Oct 25, 2021
Merged

Harmonize vehicle rental messages #774

merged 8 commits into from
Oct 25, 2021

Conversation

hbruch
Copy link

@hbruch hbruch commented Oct 19, 2021

Proposed Changes

This PR harmonizes various vehicle rental messages, e.g. by renaming bike / cycle to citybike in bikesharing context.

Further more, it uses network configuration property type (which should be refactored in future to map to GBFS vehicle formFactor) to select appropriate messages.

It might make sense to add an operator name to the user facing messages as well as distinguishing between stations and free floating vehicles. This PR does not address this yet.

Note: this WIP PR has a temporary network-renaming patch in CityBike.js which is not intended to be merged.

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

Copy link
Collaborator

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me the citybike icons don't show up. Do they for you?

I see the following errors in the console:
Screenshot from 2021-10-20 14-03-00

Also, there are linting errors which make the CI fail.

@hbruch hbruch changed the title WIP: Harmonize vehicle rental messages Harmonize vehicle rental messages Oct 22, 2021
@leonardehrenfried leonardehrenfried merged commit 282b6e6 into next Oct 25, 2021
@leonardehrenfried leonardehrenfried deleted the rentalFormFactor branch October 25, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants