Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR harmonizes various vehicle rental messages, e.g. by renaming bike / cycle to citybike in bikesharing context.
Further more, it uses network configuration property
type
(which should be refactored in future to map to GBFS vehicle formFactor) to select appropriate messages.It might make sense to add an operator name to the user facing messages as well as distinguishing between stations and free floating vehicles. This PR does not address this yet.
Note: this WIP PR has a temporary network-renaming patch in
CityBike.js
which is not intended to be merged.Pull Request Check List
Review