-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing dep with go modules #662
Conversation
Signed-off-by: Marcos G. Yedro <marcosyedro@gmail.com>
Signed-off-by: Marcos G. Yedro <marcosyedro@gmail.com>
Signed-off-by: Marcos G. Yedro <marcosyedro@gmail.com>
Signed-off-by: Marcos G. Yedro <marcosyedro@gmail.com>
Signed-off-by: Marcos G. Yedro <marcosyedro@gmail.com>
Signed-off-by: Marcos G. Yedro <marcosyedro@gmail.com>
Signed-off-by: Marcos G. Yedro <marcosyedro@gmail.com>
Signed-off-by: Marcos G. Yedro <marcosyedro@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Thinking about this more, is there a reason we created |
You are right, I will update the PR to use the "tools" folder |
Signed-off-by: Marcos G. Yedro <marcosyedro@gmail.com>
Signed-off-by: Marcos G. Yedro <marcosyedro@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
@@ -22,25 +21,23 @@ For development that requires changes to the gRPC interfaces you will need: | |||
|
|||
# Building | |||
|
|||
It is assumed that this repository lives in $GOPATH/src/github.com/spiffe/spire on your local disk, | |||
and that your GOPATH only contains one element. | |||
Since go modules are used, this repository can live in any folder on your local disk (it is not required to be in GOPATH). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a reminder here to set env flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so... It is not required to set the GO111MODULE
env flag manually if SPIRE is built using make
. This variable is exported in the Makefile (line 13).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks @marcosy !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if unset, or set to auto
, go modules mode will be automatically activated if the current directory (or a parent directory) contains a valid go.mod file. So you should be able to check out the repo, step into the directory, and run go build github.com/spiffe/spire/cmd/spire-server
and have it just work.
Pull Request check list
Affected functionality
SPIRE build experience
Description of change
Which issue this PR fixes