Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SPIRE build experience #431

Closed
evan2645 opened this issue Apr 13, 2018 · 3 comments · Fixed by #662
Closed

Improve SPIRE build experience #431

evan2645 opened this issue Apr 13, 2018 · 3 comments · Fixed by #662
Assignees

Comments

@evan2645
Copy link
Member

The current SPIRE build process requires users to have a golang directory structure on disk, with the repo checked out in the right place, in order to build properly. Investigate what it would take to eliminate this requirement, and reduce the SPIRE build to only two steps: clone then make. Implement if possible/reasonable.

@evan2645
Copy link
Member Author

Bonus points: ensure make targets are consistent across projects (SPIRE, spiffe-example, etc)

@martincapello
Copy link
Contributor

I found the following Go issues that could impact in how to approach a solution for this:
golang/go#17271 which ends up referencing golang/go#24301 as a solution.
They are pretty long discussions...24301 was created a month ago, and its last comment is 2 days ago, so this is quite recent.

@azdagron
Copy link
Member

This is now trivially achievable with go modules (introduced experimentally in go1.11).

@marcosy marcosy self-assigned this Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants