-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing dep with go modules #662
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0b82eab
Add go-modules to build system
marcosy 825ccec
Removing dep-related commands and files
marcosy 9a3d7a6
Makefile refactor, adding help target
marcosy 939dff3
Updating documentation
marcosy 7a6129b
Merge branch 'master' into adding-go-modules
marcosy 9b31901
Updating gofrs to use modules
marcosy 41f3afd
Removing missing dep references
marcosy 34a6dbe
Adding new module for tools/utils
marcosy d2fa6c3
Merge branch 'master' into adding-go-modules
marcosy f07cc12
Move utils to tools folder (recommended name)
marcosy d7bcda2
Run 'go mod tidy' in tools module
marcosy 7fbe74b
Merge branch 'master' into adding-go-modules
marcosy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a reminder here to set env flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so... It is not required to set the
GO111MODULE
env flag manually if SPIRE is built usingmake
. This variable is exported in the Makefile (line 13).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks @marcosy !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if unset, or set to
auto
, go modules mode will be automatically activated if the current directory (or a parent directory) contains a valid go.mod file. So you should be able to check out the repo, step into the directory, and rungo build github.com/spiffe/spire/cmd/spire-server
and have it just work.