Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate builder.script_files (refs: #4439) #5021

Merged
merged 1 commit into from
Jun 10, 2018
Merged

Deprecate builder.script_files (refs: #4439) #5021

merged 1 commit into from
Jun 10, 2018

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented May 28, 2018

@tk0miya tk0miya added this to the 1.8.0 milestone May 28, 2018
@tk0miya
Copy link
Member Author

tk0miya commented Jun 2, 2018

OMG, this is broken. This came from app.add_js_file() modifies Builder class directly. I'll post another PR to fix it. After that, this will work fine.

@tk0miya
Copy link
Member Author

tk0miya commented Jun 2, 2018

waiting for #5034

@tk0miya tk0miya force-pushed the 4439_deprecate_script_files branch from f11759b to 60e76a6 Compare June 9, 2018 02:53
@tk0miya tk0miya force-pushed the 4439_deprecate_script_files branch from 60e76a6 to 2476d1c Compare June 9, 2018 13:23
@codecov
Copy link

codecov bot commented Jun 9, 2018 •
edited
Loading

Codecov Report

Merging #5021 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5021      +/-   ##
==========================================
- Coverage   82.27%   82.25%   -0.03%     
==========================================
  Files         297      297              
  Lines       39076    39093      +17     
  Branches     6011     6013       +2     
==========================================
+ Hits        32150    32154       +4     
- Misses       5599     5612      +13     
  Partials     1327     1327
Impacted Files Coverage Δ
sphinx/builders/html.py 82.43% <33.33%> (-0.95%) ⬇️
sphinx/__init__.py 57.5% <0%> (-2.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eccee5e...2476d1c. Read the comment docs.

@tk0miya tk0miya merged commit 3aa686e into sphinx-doc:master Jun 10, 2018
@tk0miya tk0miya deleted the 4439_deprecate_script_files branch June 10, 2018 12:15
@tk0miya tk0miya mentioned this pull request Jun 10, 2018
Closed
astrojuanlu
astrojuanlu reviewed Sep 23, 2018
View reviewed changes
CHANGES
@@ -35,6 +35,8 @@ Incompatible changes
citations
* #4648: latex: Now "rubric" elements are rendered as unnumbered section title
* #4983: html: The URL for the productionlist has been changed
* Modifying a template variable ``script_files`` in templates is allowed now.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this say "is not allowed now"?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@astrojuanlu astrojuanlu astrojuanlu left review comments

Assignees
No one assigned
Labels
api html theme
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tk0miya @astrojuanlu