Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make script_files deprecated to? #4439

Closed
Blendify opened this issue Jan 15, 2018 · 2 comments
Closed

Make script_files deprecated to? #4439

Blendify opened this issue Jan 15, 2018 · 2 comments
Labels
html theme
Milestone
1.8.0

Comments

@Blendify
Copy link
Contributor

Blendify commented Jan 15, 2018 •
edited
Loading

Subject: script_files should be made depricated

Problem

Since css_files was made deprecated in 83d3fd2 Should script_files also be made deprecated?

Procedure to reproduce the problem

N/a

Error logs / results

N/a

Expected results

script_files marked as deprecated.

Reproducible project / your project

N/a

Environment info

  • OS: N/a
  • Python version: N/a
  • Sphinx version: 1.6.x
This was referenced Jan 16, 2018
Merged
Closed
@tk0miya tk0miya added this to the 1.8 milestone Jan 16, 2018
@tk0miya
Copy link
Member

tk0miya commented Jan 16, 2018

Yes, I think so. But we still modify it inside HTML theme. so we have to refactor it first.
So I marked this as 1.8 milestone.

@tk0miya tk0miya mentioned this issue Feb 11, 2018
Closed
tk0miya added a commit to tk0miya/sphinx that referenced this issue May 28, 2018
@tk0miya
Deprecate builder.script_files (refs: sphinx-doc#4439)
93728da
tk0miya added a commit to tk0miya/sphinx that referenced this issue May 28, 2018
@tk0miya
Deprecate builder.script_files (refs: sphinx-doc#4439)
f11759b
@tk0miya tk0miya mentioned this issue May 28, 2018
Merged
tk0miya added a commit to tk0miya/sphinx that referenced this issue Jun 9, 2018
@tk0miya
Deprecate builder.script_files (refs: sphinx-doc#4439)
60e76a6
tk0miya added a commit to tk0miya/sphinx that referenced this issue Jun 9, 2018
@tk0miya
Deprecate builder.script_files (refs: sphinx-doc#4439)
2476d1c
tk0miya added a commit that referenced this issue Jun 10, 2018
@tk0miya
Merge pull request #5021 from tk0miya/4439_deprecate_script_files
3aa686e 
Deprecate builder.script_files (refs: #4439)
@tk0miya
Copy link
Member

tk0miya commented Jun 10, 2018

Modified by #5021.
Thanks,

@tk0miya tk0miya closed this as completed Jun 10, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
html theme
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
2 participants
@tk0miya @Blendify