Add :confval:html_js_files
#5034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
force-pushed
the
add_html_js_files
branch
from
5dd2460
to
541b6fa
Compare
Codecov Report
@@ Coverage Diff @@
## master #5034 +/- ##
==========================================
+ Coverage 82.28% 82.29% +<.01%
==========================================
Files 297 297
Lines 38975 39002 +27
Branches 5990 5993 +3
==========================================
+ Hits 32072 32096 +24
- Misses 5583 5586 +3
Partials 1320 1320
Continue to review full report at Codecov.
|
tk0miya
commented
Jun 7, 2018
sphinx/builders/html.py
Outdated
| self.add_js_file(filename, **attributes) | ||
|
|
||
| for entry in self.get_builder_config('js_files', 'html'): | ||
| if isinstance(entry, string_types): |
There was a problem hiding this comment.
This conversion should be moved config-inited event like html_css_files
tk0miya
force-pushed
the
add_html_js_files
branch
from
541b6fa
to
77a98bc
Compare
tk0miya
force-pushed
the
add_html_js_files
branch
from
77a98bc
to
9fc2657
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
html_js_filesto add user JS files through configuration (likehtml_css_files)