-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leak when removing nodes #48
Conversation
When a node is removed it gets removed from the tree's `map` but not the tree's `list`, so this memory is leaked. This also fixes the assertion errors seen in spdy-http2#47 and spdy-http2/node-spdy#318 and elsewhere.
Temporarily until spdy-http2/spdy-transport#48 is fixed
`spdy` has a bug that blocks donejs usage: spdy-http2/spdy-transport#48 Until that is accepted and released we need to use this fork.
Can this be merged in order to fix btw i added changes manually and assertion error stays after refreshing browser couple of times |
hi, any updates on the issue? for the last week i've encountered the issue countless times |
Hi i have fixed it by running script on postinstall https://stackoverflow.com/questions/51419039/spdy-http2-push-throws-exception-in-angular-6-ssr |
Is anything happening with this issue? |
If anything were happening someone would have either merged it or commented on the issue. There's no need to ask. |
I pulled this into #61 which has been released in spdy-transport@3.0.0. Thanks for submitting this fix! |
When a node is removed it gets removed from the tree's
map
but not thetree's
list
, so this memory is leaked.This also fixes the assertion errors seen in #47 and
spdy-http2/node-spdy#318 and elsewhere.