Fix memory leak when removing nodes #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a node is removed it gets removed from the tree's `map` but not the tree's `list`, so this memory is leaked. This also fixes the assertion errors seen in spdy-http2#47 and spdy-http2/node-spdy#318 and elsewhere.
This was referenced Jun 26, 2017
matthewp
added a commit
to donejs/node-spdy
that referenced
this pull request
Jun 26, 2017
Temporarily until spdy-http2/spdy-transport#48 is fixed
matthewp
added a commit
to donejs/done-serve
that referenced
this pull request
Jun 26, 2017
`spdy` has a bug that blocks donejs usage: spdy-http2/spdy-transport#48 Until that is accepted and released we need to use this fork.
|
Can this be merged in order to fix btw i added changes manually and assertion error stays after refreshing browser couple of times |
|
hi, any updates on the issue? for the last week i've encountered the issue countless times |
|
Hi i have fixed it by running script on postinstall https://stackoverflow.com/questions/51419039/spdy-http2-push-throws-exception-in-angular-6-ssr |
|
Is anything happening with this issue? |
|
If anything were happening someone would have either merged it or commented on the issue. There's no need to ask. |
jacobheun
added a commit
to jacobheun/spdy-transport
that referenced
this pull request
Nov 2, 2018
jacobheun
added a commit
to jacobheun/spdy-transport
that referenced
this pull request
Nov 2, 2018
jacobheun
approved these changes
Nov 6, 2018
daviddias
pushed a commit
that referenced
this pull request
Nov 8, 2018
|
I pulled this into #61 which has been released in spdy-transport@3.0.0. Thanks for submitting this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a node is removed it gets removed from the tree's
mapbut not thetree's
list, so this memory is leaked.This also fixes the assertion errors seen in #47 and
spdy-http2/node-spdy#318 and elsewhere.