Assertion error when using server push #285
Comments
|
Have same issue. spdy:priority add node=195 parent=0 weight=256 exclusive=1 +36ms { AssertionError: false == true Happens when I press f5 several times quickly ( I use push ). |
|
I seem to have the same issue, the initial request + pushed files are fine but any requests after that seem to trigger the same assertion error. This only occurs if I hit refresh multiple times or when my service worker does a lot of requests simultaneously. I'm using the on error callback but the AssertionError still triggers a fatal error on the server. I've disabled push for now |
|
Hi all, thanks for reporting this one. It would be super helpful if you could provide a test that fails for this case, do you think you can come up with one? Thanks! |
|
I'm also having the same issue as described here and in #285. I.e. when using push I get an Output of "DEBUG=spdy:priority" up until assertion error: Click to expand
My push related code: let pushedStream = res.push(pushResrcPath, {
status: 200,
method: "GET",
request: {
accept: "*/*"
},
response: {
"content-type": mime.lookup(pushResrcPath)
}
});
pushedStream.on("error", (err) => { console.error("Push stream failed", err); });
pushedStream.on("finish", () => { console.log("Push stream finished."); });
let fileStream = fs.createReadStream(path.resolve(__dirname, path.join("../path/to/public/", pushResrcPath.replace(/^\/someprefix/i, ""))));
fileStream.pipe(pushedStream);
FWIW: I'm using Node.js v6.9.1 in combination with Express v4.15.2 on Windows 10. |
|
I can replicate this reliably by pushing many assets, which I think simulates the action of this constantly refreshing people are reporting. Here's my example, perhaps someone could form this into a test case for @diasdavid if it doesn't help on it's own? |
|
The following single-file example also causes the AssertionError to be thrown on my development machine. const spdy = require("spdy");
const options = {
key: `-----BEGIN RSA PRIVATE KEY-----
MIIEpAIBAAKCAQEA7aSwMfFw5naEJ6MlTS53cYrnkF6DyrQuHWMOTOgtEfY1XWjrHEUdfz4xvn4/LAOWpsFP/YkIaYHlLAez3ZybjEaSH/T/jqpDmO4VSbSfdxzJJHV8sTO7G6gtHkGFiDMOKCBDi1Htrx7e8kY39c8j5ZFfSZEXugZIuUTnd0lipp0dGbsSKoqHVm1NMssm0zvfWnkrv//N7lY0npeqmwcIy5aPN5mhGtt6YK9+LolcwWssyX2e4vBBKpZQVtISSpV8PscmL+iv9nr+LHWbo3VrZ63RHlTuRDhX1Ivv9Hqx+b8T/cZCD94MLT/PA3CS0PO+h7Kdds8LDm0SL3OFi8gAPwIDAQABAoIBAQDRTi4JrvebZGM9bgoakoSNMqSFmVlGna/IHkioIA4iNdIGtbPuMEmsmqDBgPwuzfJQaQ8E5T7NfqTUROx8kcTGphlpoCW+B+SFu5xwUG/rPyVBwWDTyhZQY61papgrv5wGZ3RWLxDDHtOKW6JKE+kv9vwQFYTqSUKgOzoK7E3BJAnTbbQRGMAYPRlsrrwKw3C2WfxCpYhwHSDD/xJbMCjzRL0RG37om8pvTUAn0XU8cmG1kuu5DlOZ2kYXbCU9RE5iuhDSwkj4aQ2gzVpIMV3AM5IxEDrzqe8Uvs5FzpI47gAdX8zusWD8mnbNLickkf8dRANAJXz3yqQy7cif+i0hAoGBAPazElhlCSLB9q8vwTk6h7/ObpoLxWtUgMGldpmf77QS6VnihURAaawyw50lPavWPBT2WXgKPCQvZjCw14fn31SG7PlAFkuiuiF3sYYfYh3pjvRnr58iEbGrP/UyCJbPvEfbYL+MG7tWKJBABzYe0zivJDsqwYNsvSo9qAFUwi05AoGBAPaaNtX3TG7frTAGCUJ3xW5eIGVQspQ/maSa8nhaEeSY01ATjbkuhWmdO9Pi1izg96CsQsG39HZ/WmGLsg0ZF3q83KJxunq0DlMWTl03CACgU6DvXkArhdJrjE9TCtlgdGIfJoNUG4PTW+J4tA5H6VEUudhdxaQ9qSWll46xC5E3AoGAfp2BuOSCP9iVJ2y3GwwzR/pHQcDw3hlMzBaEPGydtipOoddk1pbIpZyYUTsf3+XgiFG3sahvHZNGO49Hz3TuZo+paHO//anTJgIsls3cqcWJnV7qAB6YPjvKY6n+Rojv9WFe0nCyev/Jad+y09AWUG1zhvp2v2E75UYnyCccUeECgYEAsP2cD9OvYwBc79PVP4RxCja6b50MnsRLBM5E6sZSg0yAlb+C/375OAUm1HvBFnLcp9AbFahu58Gd39cAktAIfwogHOMdYUXr5gxjcBm4P6LSgvZqIgpawNx51tEWP1AwF+CdprJuER5Ym2HgcUOBnLUQcc9Ts/6hcSi5byt4zt8CgYB7UYogvtn2UwLcWr4QmThNuLkPrBevZ9buD0k2hTRY1OVej7uCDYC7rI4NVS/Nf7/0brwCUZVsWrwBuIDuxGAn2T9ezvWx2Q7/X50ZuvcXAQWIvELb5VTbrJWKKUaZXxo7IJJ5hZrTj0TPrvpIsECPkVWD6wQy3qroDg6gEgsRqA==
-----END RSA PRIVATE KEY-----
`,
cert: `-----BEGIN CERTIFICATE-----
MIIDBjCCAe4CCQC1b57lEU3qJTANBgkqhkiG9w0BAQsFADBFMQswCQYDVQQGEwJBVTETMBEGA1UECAwKU29tZS1TdGF0ZTEhMB8GA1UECgwYSW50ZXJuZXQgV2lkZ2l0cyBQdHkgTHRkMB4XDTE3MDUyOTEzNTE1OFoXDTE5MDUyOTEzNTE1OFowRTELMAkGA1UEBhMCQVUxEzARBgNVBAgMClNvbWUtU3RhdGUxITAfBgNVBAoMGEludGVybmV0IFdpZGdpdHMgUHR5IEx0ZDCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAO2ksDHxcOZ2hCejJU0ud3GK55Beg8q0Lh1jDkzoLRH2NV1o6xxFHX8+Mb5+PywDlqbBT/2JCGmB5SwHs92cm4xGkh/0/46qQ5juFUm0n3ccySR1fLEzuxuoLR5BhYgzDiggQ4tR7a8e3vJGN/XPI+WRX0mRF7oGSLlE53dJYqadHRm7EiqKh1ZtTTLLJtM731p5K7//ze5WNJ6XqpsHCMuWjzeZoRrbemCvfi6JXMFrLMl9nuLwQSqWUFbSEkqVfD7HJi/or/Z6/ix1m6N1a2et0R5U7kQ4V9SL7/R6sfm/E/3GQg/eDC0/zwNwktDzvoeynXbPCw5tEi9zhYvIAD8CAwEAATANBgkqhkiG9w0BAQsFAAOCAQEAb4AIPuALBtOEDMhIi2wRDt9b88XewLJDejkl8o1GRs0FlknvYh+wawe4FuZqBhso6Mi/INqWsmFQbQWXX5PGyFhtw1wsGLJ7el+2Tmv3frGTxAJnhmouu60b1Vh8r9jGvbYn4Kdo7+5YrfuUbebl/RuOjYTcom4QdMMehXiWADMrSAa/7SZmKhODskWyRgLFMUsDe8UHJt/8HVgVila9GIVXY/Toq+JMFTU7oEydW2DohrOvERUpx/VnVVwH89AdM1tUDM0sgsSWoM69R+g6cFtMg8/HqSWYrPw0+jACpSgZ8ekYMPk55gYWKccoK8K+DCaFJVQhu0S1FhzTNRw/og==
-----END CERTIFICATE-----`,
spdy: { protocols: ["h2"], plain: false }
};
let htmlContent = `<html><head><title>Push error page</title><link rel="stylesheet" href="css/main.css"></head><body>`;
for ( let i = 0; i < 100; ++i ) {
htmlContent += `<img src="img/img${i}.svg">`;
}
htmlContent += `</body></html>`;
const cssContent = `body { background-image: url("../img/hero.svg"); background-size: cover; background-color: gray; } img { float: left; padding: 1vh; width: 5vw; }`;
const heroSvg = `<svg width="25" height="25" xmlns="http://www.w3.org/2000/svg"><defs><linearGradient id="grad" x1="0" x2="1" y1="0" y2="1"><stop offset="0" stop-color="black"/><stop offset="1" stop-color="darkgrey"/></linearGradient></defs><rect width="25" height="25" fill="url(#grad)"/></svg>`;
function requestHandler(req, res) {
if ( req.url == "/" || req.url == "/index.html" ) {
let pushStream = res.push("/img/hero.svg", {
status: 200,
method: "GET",
request: { accept: "*/*" },
response: { "content-type": "image/svg+xml" }
});
pushStream.on("error", (err) => { console.error("Push stream error:", err) });
// IMPORTANT If we don't introduce a (not-too-low) delay here, then the push AssertionError doesn't seem to be thrown. (On my PC the delay needed to be > ~20ms.)
setTimeout(() => {
pushStream.end(heroSvg);
}, 100);
res.writeHead(200);
res.end(htmlContent);
} else if ( req.url == "/css/main.css" ) {
res.writeHead(200, { "content-type": "text/css" });
res.end(cssContent);
} else if ( req.url.startsWith("/img/") ) {
// Note: If we wouldn't push "hero.svg" it would also be served as a randomly solid color filled rectangle.
res.writeHead(200, { "content-type": "image/svg+xml" });
res.end(`<?xml version="1.0"?><svg width="25" height="25" xmlns="http://www.w3.org/2000/svg" version="1.1"><rect width="25" height="25" fill="rgb(${Math.floor(Math.random()*256)},${Math.floor(Math.random()*256)},${Math.floor(Math.random()*256)})"/></svg>`);
} else {
res.writeHead(404);
res.end();
}
}
spdy.createServer(options, requestHandler).listen(3000);
console.log("Server running @ https://127.0.0.1:3000/");One important thing to note is that for the error to occur I had to introduce an artificial delay for the response of the push by using (Note: The included key and (self-signed) certificate were generated just for the example.) |
6 tasks
|
Any updates on this? |
|
Any update on this issue? What might be causing this issue? |
|
Same here. After hitting browser refresh few times i got same error. Any updates on this? Or we would not be able to use push for ages because it seems like this issue is quite old. It |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following the server-push example, I am using a slightly adapted version:
When refreshing the browser a couple of times in a row, I get the following assertion error:
Note that the server-pushed file is relatively large (4MB).
Might this be related to the closed issue #244 ?
I'm using Express as well btw.
The text was updated successfully, but these errors were encountered: