fix: add updates from spdy-http2#48

jacobheun · Nov 2, 2018 · 95f648d · 95f648d
1 parent eedec4d
commit 95f648d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/spdy-transport/priority.js b/lib/spdy-transport/priority.js
@@ -184,5 +184,7 @@ PriorityTree.prototype.addDefault = function addDefault (id) {
 
 PriorityTree.prototype._removeNode = function _removeNode (node) {
   delete this.map[node.id]
+  var index = utils.binarySearch(this.list, node, compareChildren)
+  this.list.splice(index, 1)
   this.count--
 }
diff --git a/test/base/priority-test.js b/test/base/priority-test.js
@@ -152,4 +152,12 @@ describe('Stream Priority tree', function () {
 
     assert.strictEqual(tree.get(1).weight, 16)
   })
+
+  it('Removing a node should remove it from the tree\'s list', function () {
+    tree.addDefault(1)
+
+    tree.get(1).remove()
+
+    assert.strictEqual(tree.list[0], undefined)
+  })
 })