Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP-3550: Multi-integration jump detection #242

Merged
merged 219 commits into from
Mar 20, 2024
Merged

JP-3550: Multi-integration jump detection #242

merged 219 commits into from
Mar 20, 2024

Conversation

mwregan2
Copy link
Collaborator

@mwregan2 mwregan2 commented Feb 21, 2024 •
edited by hbushouse
Loading

Resolves JP-3550

Closes spacetelescope/jwst#8300

This PR addresses the problem of jump detection in integrations with a small number of groups. By combining all the integrations in the search for outliers, the jump step can mask the jumps with a significantly larger sensitivity.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

mwregan2 added 30 commits May 24, 2022 10:21
@mwregan2
Merge pull request #1 from spacetelescope/main
69341a0 
Get up to date May 24, 2022
@mwregan2
Merge pull request #2 from spacetelescope/main
12282e7 
update on 7/8/22
@mwregan2
Merge pull request #3 from spacetelescope/main
48c9ceb 
getting up to date Aug 22
@mwregan2
Merge pull request #4 from spacetelescope/main
dbe7f18 
catch up
@mwregan2
Merge branch 'spacetelescope:main' into main
6cded7f
@mwregan2
changes for charge spilling from saturated core
93ee699
@mwregan2
Update jump.py
533ec24
@mwregan2
Update jump.py
7d4f07e
@mwregan2
Update jump.py
dc8f521
@mwregan2
Update saturation.py
7c064ce
@mwregan2
Update saturation.py
f7880c6
@mwregan2
use ellipses for all jumps
7f04b48
@mwregan2
Update jump.py
00c30a7
@mwregan2
Update jump.py
14e3cf6
@mwregan2
Update jump.py
44e1e07
@mwregan2
Update jump.py
e3a1c74
@mwregan2
Update jump.py
36e478a
@mwregan2
Update jump.py
005a7e2
@mwregan2
Update jump.py
7208ef5
@mwregan2
Update jump.py
9821952
@mwregan2
Update jump.py
e3a5f7f
@mwregan2
Update jump.py
69d5a9a
@mwregan2
fix sat expand
b7efb11
@mwregan2
fix inside ellipse test
8d65179
@mwregan2
Update jump.py
ca6df08
@mwregan2
Update jump.py
c7f6c5f
@mwregan2
Update jump.py
e907be0
@mwregan2
tests etc
8852967
@mwregan2
return new dgq for sat expend
6b4f6eb
@mwregan2
fix super expanding ellipses
92801a4
@hbushouse hbushouse changed the title Multi int jump detection JP-3550: Multi-integration jump detection Mar 1, 2024
hbushouse
hbushouse requested changes Mar 18, 2024
View reviewed changes
src/stcal/jump/jump.py Outdated Show resolved Hide resolved
src/stcal/jump/jump.py Outdated Show resolved Hide resolved
src/stcal/jump/jump.py Outdated Show resolved Hide resolved
src/stcal/jump/jump.py Outdated Show resolved Hide resolved
src/stcal/jump/twopoint_difference.py Show resolved Hide resolved
src/stcal/jump/twopoint_difference.py Outdated Show resolved Hide resolved
src/stcal/jump/twopoint_difference.py Outdated Show resolved Hide resolved
src/stcal/jump/twopoint_difference.py Outdated Show resolved Hide resolved
src/stcal/jump/twopoint_difference.py Show resolved Hide resolved
tests/test_jump.py Outdated Show resolved Hide resolved
hbushouse
hbushouse approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK now.

@hbushouse hbushouse merged commit def387c into spacetelescope:main Mar 20, 2024
23 of 25 checks passed
@stscijgbot-jp stscijgbot-jp mentioned this pull request Mar 20, 2024
Closed
@hbushouse hbushouse mentioned this pull request Mar 20, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmacdonald-stsci kmacdonald-stsci kmacdonald-stsci approved these changes

@hbushouse hbushouse hbushouse approved these changes

Assignees
No one assigned
Labels
jump ramp_fitting testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jump Step should process all integrations at once
3 participants
@mwregan2 @hbushouse @kmacdonald-stsci