getting up to date Aug 22 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* automatically add labels to pull requests based on changed files * remove `GLS` labeling (part of ramp fitting)
…Shape (#109) AL-579: Updating GLS processing and fixed tests for multi-integrations. (#108) * Updating GLS processing and fixed tests for multi-integrations. * Updating change log. * Updating tests. * Updated the change log. * Removing unnecessary code. Corrected the dimension problem for the DQ array, as well as changed variable names to make more sense. Updating tests and removing debugging code. Updating the change log. Making changes due to style failures.
* Making style changes. * Removed set trace * Updating change log. * Updating change log.
* First attempt at fixing the NaN and DO_NOT_USE bug. Updating handling NaNs in the rateints product, as well as the DQ flags associated with those NaNs. Updating the change log. * Removing unneeded np.where.
* Fixed bad gain value test. * Fixing style issues. * Removing unnecessary comments. * Updating change log. * Changing comment. * Adding more detail to the change log. * Expanding change log comment.
* initial flag n groups after jump * adding log messages * updating to 2 thresholds and 2 # of groups * parameter passing works and adding DN thresholds * after_jump flagging is working * fully working! * bug in the non-working code fixed * moving after_flags parameters to keywords and adding tests * adjusting for jumps in electrons not DNs * fix too long line * adding to change log * changes in right section now * fixing keywords * fixing tests for revised keywords * responding to PR comments * Address in PR comments
* Jump modifies input data by gain multiplier (JP-2696). * Update PR number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-nnnn
Resolves RCAL-nnnn
Closes #
This PR addresses ...
Checklist
CHANGES.rst(either inBug FixesorChanges to API)