Jump modifies input data by gain multiplier (JP-2696). #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
==========================================
- Coverage 72.44% 72.35% -0.09%
==========================================
Files 16 16
Lines 2533 2536 +3
==========================================
Hits 1835 1835
- Misses 698 701 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
PaulHuwe
approved these changes
Aug 18, 2022
ddavis-stsci
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
LGTM & passes regression tests,
https://plwishmaster.stsci.edu:8081/me/my-views/view/all/job/RT/job/romancal/612/
hbushouse
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-2696
Closes spacetelescope/jwst#6944
This PR addresses spacetelescope/jwst#6944 - "Jump detection modifies input data by gain multiplier". In this step the data in the input object is multiplied by the gain (converting from DN to electrons) within the algorithm. This PR reconverts that data back to DN at the end of the step. This solves the user's problem of not being able to test multiple jump detection parameters using the same input.
Checklist
CHANGES.rst(either inBug FixesorChanges to API)