JP-3550: Jump multi int

[mwregan2]

This PR addresses the need to have a new parameter in the jump step that controls when the jump code switches from the iterative flagging of jumps to flagging all outliers at once.

Checklist for maintainers

• added entry in CHANGES.rst within the relevant release section
• updated or added relevant tests
• updated relevant documentation
• added relevant milestone
• added relevant label(s)
• ran regression tests, post a link to the Jenkins job below.
  How to run regression tests on a PR
• Make sure the JIRA ticket is resolved properly

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.23%. Comparing base (2fb073e) to head (40c94a4).
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8304      +/-   ##
==========================================
- Coverage   75.31%   75.23%   -0.08%     
==========================================
  Files         474      474              
  Lines       38965    38999      +34     
==========================================
- Hits        29345    29342       -3     
- Misses       9620     9657      +37     

Flag	Coverage Δ		*Carryforward flag
nightly	77.33% <ø> (-0.01%)	⬇️	Carriedforward from 60834b7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hbushouse]

@mwregan2 Now that spacetelescope/stcal#242 has been merged, this PR is the one that's needed to enable the use of the new parameter, right?

[mwregan2]

Right

[hbushouse]

Right

OK, I'll kick off a regression test run using this PR branch and the latest stcal/main, which contains the necessary updates on that side.

[hbushouse]

Regression test started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1327

[hbushouse]

First attempt at regtest was messed up. New run started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1331/

[emolter]

Regression tests were failing due to duplicated keywords in the spec string. LGTM once that is fixed; my other comments were tiny wording changes

[mwregan2]

Ned, Thanks for looking at this. I’ve removed the duplicate parameters and updated changes.rst. Mike From: Ned Molter ***@***.***> Reply-To: spacetelescope/jwst ***@***.***> Date: Thursday, March 21, 2024 at 10:21 AM To: spacetelescope/jwst ***@***.***> Cc: Michael Regan ***@***.***>, Mention ***@***.***> Subject: Re: [spacetelescope/jwst] JP-3550: Jump multi int (PR #8304) @emolter requested changes on this pull request. Regression tests were failing due to duplicated keywords in the spec string. LGTM once that is fixed; my other comments were tiny wording changes

________________________________ In jwst/jump/jump_step.py<https://urldefense.com/v3/__https:/github.com/spacetelescope/jwst/pull/8304*discussion_r1533992323__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!3eBfzucKtzpETv-WYb-hK1MShhyQVEWLgBkXgVH4JeFgiHBlnb6X0icihl1WXMrU2ifrBvUsuEd8bbZwP3QFHfc$>:

@@ -36,15 +36,18 @@ class JumpStep(Step):

use_ellipses = boolean(default=False) # deprecated sat_required_snowball = boolean(default=True) # Require the center of snowballs to be saturated min_sat_radius_extend = float(default=2.5) # The min radius of the sat core to trigger the extension of the core - sat_expand = integer(default=2) # Number of pixels to add to the radius of the saturated core of snowballs - edge_size = integer(default=25) # Size of region on the edges of NIR detectors where a sat core is not required - find_showers = boolean(default=False) # Turn on shower flagging for MIRI + sat_expand = integer(default=2) # Number of pixels to add to the radius of the saturated core of snowballs ⬇️ Suggested change - sat_expand = integer(default=2) # Number of pixels to add to the radius of the saturated core of snowballs

________________________________ In jwst/jump/jump_step.py<https://urldefense.com/v3/__https:/github.com/spacetelescope/jwst/pull/8304*discussion_r1533992783__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!3eBfzucKtzpETv-WYb-hK1MShhyQVEWLgBkXgVH4JeFgiHBlnb6X0icihl1WXMrU2ifrBvUsuEd8bbZw9oj25as$>:

@@ -36,15 +36,18 @@ class JumpStep(Step):

use_ellipses = boolean(default=False) # deprecated sat_required_snowball = boolean(default=True) # Require the center of snowballs to be saturated min_sat_radius_extend = float(default=2.5) # The min radius of the sat core to trigger the extension of the core - sat_expand = integer(default=2) # Number of pixels to add to the radius of the saturated core of snowballs - edge_size = integer(default=25) # Size of region on the edges of NIR detectors where a sat core is not required - find_showers = boolean(default=False) # Turn on shower flagging for MIRI + sat_expand = integer(default=2) # Number of pixels to add to the radius of the saturated core of snowballs + expand_large_events = boolean(default=False) # Turns on Snowball detector for NIR detectors ⬇️ Suggested change - expand_large_events = boolean(default=False) # Turns on Snowball detector for NIR detectors

________________________________ In CHANGES.rst<https://urldefense.com/v3/__https:/github.com/spacetelescope/jwst/pull/8304*discussion_r1534004499__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!3eBfzucKtzpETv-WYb-hK1MShhyQVEWLgBkXgVH4JeFgiHBlnb6X0icihl1WXMrU2ifrBvUsuEd8bbZwDeNvpZU$>:

+- Add an additional parameter to pass the threshold number of difference to switch

+ the jump detection to run in a single pass rather than one CR at a time. [#8304] + ⬇️ Suggested change

-- Add an additional parameter to pass the threshold number of difference to switch - the jump detection to run in a single pass rather than one CR at a time. [#8304] - +- Added an additional parameter to the jump step that sets the threshold number of differences + below which iterative flagging of a single CR at a time is turned off. [#8304] +

________________________________ In jwst/jump/jump_step.py<https://urldefense.com/v3/__https:/github.com/spacetelescope/jwst/pull/8304*discussion_r1533994703__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!3eBfzucKtzpETv-WYb-hK1MShhyQVEWLgBkXgVH4JeFgiHBlnb6X0icihl1WXMrU2ifrBvUsuEd8bbZwhnejRtY$>:

@@ -36,15 +36,18 @@ class JumpStep(Step):

use_ellipses = boolean(default=False) # deprecated sat_required_snowball = boolean(default=True) # Require the center of snowballs to be saturated min_sat_radius_extend = float(default=2.5) # The min radius of the sat core to trigger the extension of the core - sat_expand = integer(default=2) # Number of pixels to add to the radius of the saturated core of snowballs - edge_size = integer(default=25) # Size of region on the edges of NIR detectors where a sat core is not required - find_showers = boolean(default=False) # Turn on shower flagging for MIRI + sat_expand = integer(default=2) # Number of pixels to add to the radius of the saturated core of snowballs + expand_large_events = boolean(default=False) # Turns on Snowball detector for NIR detectors regression test failures were caused by these two keywords being duplicated.

________________________________ In CHANGES.rst<https://urldefense.com/v3/__https:/github.com/spacetelescope/jwst/pull/8304*discussion_r1534006892__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!3eBfzucKtzpETv-WYb-hK1MShhyQVEWLgBkXgVH4JeFgiHBlnb6X0icihl1WXMrU2ifrBvUsuEd8bbZwdykU3Mo$>:

+- Add an additional parameter to pass the threshold number of difference to switch

+ the jump detection to run in a single pass rather than one CR at a time. [#8304] + I'm not picky on the wording, but what's there currently was a bit confusing — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/spacetelescope/jwst/pull/8304*pullrequestreview-1952345373__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!3eBfzucKtzpETv-WYb-hK1MShhyQVEWLgBkXgVH4JeFgiHBlnb6X0icihl1WXMrU2ifrBvUsuEd8bbZwXsQU9DY$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AF6KJLRGAJQSY6SDOWYPTXLYZLUIHAVCNFSM6AAAAABDVQAMBGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJSGM2DKMZXGM__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!3eBfzucKtzpETv-WYb-hK1MShhyQVEWLgBkXgVH4JeFgiHBlnb6X0icihl1WXMrU2ifrBvUsuEd8bbZwyxWbinM$>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[hbushouse]

Finally got a successful regtest run at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1341/ All differences are expected due to the updates here, as well as unrelated ref file updates. So it looks OK.