2023.10 #1242

javierggt · 2024-01-09T23:14:08Z

ska3-flight 2023.10

This PR includes:

chandra_aca:
- Add new functions to get Earth boresight angles and Earth block intervals
- Improve accuracy and speed of planet functions
kadi
- Improve Command and Command not run events
  - now correctly supports cut-and-paste from Backstop text with no text edits required
- Add support of "HRC not run" event type to handle HRC being disabled
- Change limits in SPM and off-nom-roll validators to fix violations
proseco.
- Apply temperature-dependent drift model offset to fid positions
ska_sun
- change default sun position method to new accurate method.

This PR also moves the skare3_tools package (utilities for maintainers for working with skare3) out of the ska3-flight metapackage. The intent is that with our FSDS request to approve this PR we will also receive approval to delegate that skare3_tools package to ACA-only control to then be maintained under our non-FSDS package process.

Interface Impacts:

Suppress setuptools_scm warning (git archive did not support describe output)
proseco:
- Change default behavior to apply offsets in y and z to expected fid positions via chandra_aca.drift.get_fid_offset. Respects new environment variable PROSECO_ENABLE_FID_OFFSET .
kadi:
- Format for Command and Command not run event Params changed to match the existing documentation (see link in the Sheet).
- Supports new HRC not run entry on Events Sheet.
chandra_cmd_states package discontinued. Importing it raises an exception unless SKA_ALLOW_DISCONTINUED_PACKAGES=1
new functions
- chandra_aca.get_earth_boresight_angle
- chandra_aca.get_earth_blocks
- paths functions / classes in parse_cm top level
- add Quaternion.QuatDescr and Quaternion.QuatLike
- Add cxotime.CxoTimeDescr, cxotime.CxoTimeLike and cxotime.CxoTime.NOW
ska_sun.position_at_jd was renamed to ska_sun.position_fast_at_jd to clarify that this function does not respect the sun_position_method_default configuration value.

Testing:

skare3 dashboard and test result password at https://icxc.cfa.harvard.edu/aspect/skare3_dash_cred.txt

The latest release candidates will be installed in /proj/sot/ska3/test on HEAD, and all release candidates will be available for testing from the usual channels:

conda create -n ska3-flight-2023.10rc5 --override-channels \
  -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/flight \
  -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/test \
  ska3-flight==2023.10rc5

Review

All operations critical or impacting PR's are independently and carefully reviewed. For other PR's the level of detail for review is calibrated to operations criticality. Some PR's that are confined to aspect-team-specific processing may have little to no independent review.

Deployment

ska3-flight 2023.10 will be promoted to flight conda channel and installed on HEAD and GRETA Linux upon approval of FSDS Jira ticket.

Code changes

ska3-core (2023.3 -> 2023.10rc4)

New Packages

astropy-iers-data: 0.2024.1.8.0.30.55

ska3-core-latest (2023.3 -> 2023.10rc4)

New Packages

astropy-iers-data:

ska3-flight (2023.9 -> 2023.10rc4)

Removed Packages

skare3_tools

Updated Packages

aca_view: 0.13.0 -> 0.14.0 (0.13.0 -> 0.14.0)
- PR 172 (Javier Gonzalez): add kadi_commands_scenario setting to data service
acis_thermal_check: 4.7.0 -> 4.8.0 (4.7.0 -> 4.8.0)
- PR 68 (John ZuHone): Change namespace package imports and update answers after updated sun position calculation
- PR 66 (John ZuHone): Fixing ruff and black linting
agasc: 4.17.1 -> 4.18.0 (4.17.1 -> 4.18.0)
- PR 162 (Javier Gonzalez): fix typo in filename in test_agasc_2.py::test_write
- PR 161 (Javier Gonzalez): move some functions from create_derived_agasc_h5.py
chandra_aca: 4.44.0 -> 4.45.0 (4.44.0 -> 4.45.0)
- PR 164 (Tom Aldcroft): Add new functions to get Earth boresight angles and Earth block intervals
- PR 159 (Javier Gonzalez): Make maude_decom.get_aca_images robust agains missing/repeated frames
- PR 163 (Tom Aldcroft): Allow None input to convert_time_format_spk
- PR 162 (Tom Aldcroft): Improve accuracy and speed of planet functions
chandra_cmd_states: 4.0.0 -> 4.1.0 (4.0.0 -> 4.1.0)
- PR 68 (Tom Aldcroft): Discontinue support for chandra_cmd_states
chandra_maneuver: 4.1.0 -> 4.2.0 (4.1.0 -> 4.2.0)
- PR 27 (Tom Aldcroft): Use efficient ska_sun pitch and off_nom_roll methods
cheta: 4.60.0 -> 4.61.0 (4.60.0 -> 4.61.0)
- PR 254 (Jean Connelly): Update computed pitch expected vals for a regression test
- PR 253 (Tom Aldcroft): Add a negative lookahead assertion for log check
- PR 252 (Tom Aldcroft): Ruff format and lint and tidy top-level
cxotime: 3.7.0 -> 3.8.0 (3.7.0 -> 3.8.0)
- PR 43 (Tom Aldcroft): Add CxoTimeDescr descriptor and CxoTime.NOW sentinel
- PR 41 (Tom Aldcroft): Ruff format and linting
kadi: 7.7.1 -> 7.8.0 (7.7.1 -> 7.8.0)
- PR 308 (Tom Aldcroft): Improve Command and Command not run events
- PR 309 (Tom Aldcroft): Add "HRC not run" event to handle HRC being disabled
- PR 307 (Tom Aldcroft): Fix, document, and test get_rltt and get_schedule_stop_time
- PR 302 (Tom Aldcroft): Add email notifications for validation violations
- PR 305 (Tom Aldcroft): Change limits in SPM and off-nom-roll validators to fix violations
- PR 304 (Tom Aldcroft): Update code and tests for use with ska_sun accurate position
- PR 301 (Tom Aldcroft): flatten namespace package names
- PR 295 (Tom Aldcroft): Use cached property in commands validation
mica: 4.34.0 -> 4.34.1 (4.34.0 -> 4.34.1)
- PR 287 (Jean Connelly): Update test colnames for DS 10.12.3 outputs
parse_cm: 3.13.0 -> 3.14.0 (3.13.0 -> 3.14.0)
- PR 46 (Tom Aldcroft): Sort file paths in load_file_paths function
- PR 45 (Tom Aldcroft): Add functions related to load file names and paths
proseco: 5.11.0 -> 5.12.0 (5.11.0 -> 5.12.0)
- PR 390 (Tom Aldcroft): Add Row type aliases
- PR 389 (Jean Connelly): Rename a test so error isn't in the name
- PR 388 (Jean Connelly): Apply temperature-dependent drift model offset to fid positions
quaternion: 4.2.0 -> 4.3.0 (4.2.0 -> 4.3.0)
- PR 45 (Tom Aldcroft): Update QuatDescriptor for typed-descriptor-lazy-default
- PR 44 (Tom Aldcroft): Add QuatDescriptor descriptor and QuatLike type alias
ska_helpers: 0.13.0 -> 0.14.0 (0.13.0 -> 0.14.0)
- PR 54 (Tom Aldcroft): Coerce TypedDescriptor default at instance creation
- PR 53 (Tom Aldcroft): Add TypedDescriptor class for typed descriptors
- PR 52 (Tom Aldcroft): Suppress the setuptools_scm warning
ska_sun: 3.12.0 -> 3.13.0 (3.12.0 -> 3.13.0)
- PR 36 (Tom Aldcroft): Change default sun position method to accurate and other minor improvements
sparkles: 4.24.1 -> 4.25.0 (4.24.1 -> 4.25.0)
- PR 203 (Tom Aldcroft): Factor checks out of ACAReviewTable class
- PR 202 (Jean Connelly): Update test data with proseco fid offsets
- PR 201 (Jean Connelly): Update tests for ska_sun change to position_accurate
starcheck: 14.6.0 -> 14.7.0 (14.6.0 -> 14.7.0)
- PR 432 (Jean Connelly): Add up NMM time before NPNT states to calculate maneuver equiv angle
- PR 431 (Jean Connelly): Add fid offset support
xija: 4.31.0 -> 4.31.1 (4.31.0 -> 4.31.1)
- PR 135 (Tom Aldcroft): Use cheta not Ska.engarchive

ska3-flight-latest (2023.7 -> 2023.10rc4)

New Packages

chandra_limits:

Removed Packages

skare3_tools

Related Issues

Fixes #1223
Fixes #1224
Fixes #1225
Fixes #1226
Fixes #1227
Fixes #1228
Fixes #1229
Fixes #1230
Fixes #1231
Fixes #1232
Fixes #1233
Fixes #1234
Fixes #1235
Fixes #1236
Fixes #1237
Fixes #1238
Fixes #1239
Fixes #1240
Fixes #1241

jeanconn · 2024-01-10T23:18:05Z

pkg_defs/ska3-flight-latest/meta.yaml

@@ -49,7 +49,6 @@ requirements:
    - ska_helpers
    - ska_path
    - ska_sync
-    - skare3_tools


Should probably add it to the non fsds yaml file in this PR.

jeanconn · 2024-01-11T17:26:52Z

pkg_defs/ska3-flight/meta.yaml

@@ -42,15 +42,14 @@ requirements:
    - ska_parsecm ==4.0.0
    - ska_quatutil ==4.0.0
    - ska_shell ==4.0.1
-    - ska_sun ==3.12.0
+    - ska_sun ==3.13.0
    - ska_tdb ==4.0.0
    - ska3-core ==2023.3


Doesn't this (ska3-core) need an update to get the astropy-iers-data thingy?

I think so. I wonder how the tests passed

Right, the file in HEAD /proj/sot/ska3/test there has the right date, but did you do that manually yesterday morning? If so it would pass tests from that.

jeanconn-fido> grep expires /proj/sot/ska3/test/lib/python3.10/site-packages/astropy/utils/iers/data/Leap_Second.dat # File expires on 28 June 2024 jeanconn-fido> ls -l /proj/sot/ska3/test/lib/python3.10/site-packages/astropy/utils/iers/data/Leap_Second.dat -rw-rw-r-- 2 aca aspect 1352 Jan 10 10:45 /proj/sot/ska3/test/lib/python3.10/site-packages/astropy/utils/iers/data/Leap_Second.dat

increase package versions for 2023.10

c142961

javierggt changed the title ~~increase package versions for 2023.10~~ 2023.10 Jan 9, 2024

increase ska3-flight version

e9bbf47

javierggt force-pushed the 2023.10-branch branch from 8814b85 to e9bbf47 Compare January 9, 2024 23:33

javierggt added 4 commits January 10, 2024 12:04

add astropy-iers-data to ska3-core and ska3-core-latest

acbcb5a

remove skare3_tools

84cc77f

fix version again

0050746

bump acis_thermal_check version

c972c7e

jeanconn reviewed Jan 11, 2024

View reviewed changes

javierggt added 2 commits January 11, 2024 14:57

add skare3_tools to environment-non-fsds.yml

912aec9

use current ska3-core, and increase versions of kadi and parse_cm

2a0974c

javierggt merged commit ef66ab1 into master Jan 22, 2024
12 of 14 checks passed

javierggt deleted the 2023.10-branch branch January 22, 2024 16:55

javierggt modified the milestones: TBD (Matlab 2024_010), 2023.10 Jan 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2023.10 #1242

2023.10 #1242

javierggt commented Jan 9, 2024 •

edited

Loading

jeanconn Jan 10, 2024

javierggt Jan 11, 2024

jeanconn Jan 11, 2024 •

edited

Loading

javierggt Jan 11, 2024

jeanconn Jan 11, 2024

javierggt Jan 11, 2024

2023.10 #1242

2023.10 #1242

Conversation

javierggt commented Jan 9, 2024 • edited Loading

ska3-flight 2023.10

Interface Impacts:

Testing:

Review

Deployment

Code changes

ska3-core (2023.3 -> 2023.10rc4)

New Packages

ska3-core-latest (2023.3 -> 2023.10rc4)

New Packages

ska3-flight (2023.9 -> 2023.10rc4)

Removed Packages

Updated Packages

ska3-flight-latest (2023.7 -> 2023.10rc4)

New Packages

Removed Packages

Related Issues

jeanconn Jan 10, 2024

Choose a reason for hiding this comment

javierggt Jan 11, 2024

Choose a reason for hiding this comment

jeanconn Jan 11, 2024 • edited Loading

Choose a reason for hiding this comment

javierggt Jan 11, 2024

Choose a reason for hiding this comment

jeanconn Jan 11, 2024

Choose a reason for hiding this comment

javierggt Jan 11, 2024

Choose a reason for hiding this comment

javierggt commented Jan 9, 2024 •

edited

Loading

jeanconn Jan 11, 2024 •

edited

Loading