Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test colnames for DS 10.12.3 outputs #287

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Dec 14, 2023

Description

Update test colnames for DS 10.12.3 outputs.
This is just renaming 'noao' to 'noirlab'.

Interface impacts

Testing

Unit tests

  • Mac

Independent check of unit tests by @taldcroft

  • Mac

Functional tests

No functional changes or functional testing.

Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. In general we should apply black formatting to an entire package along with the supporting files for CI / pre-commit / ruff config. But fine with this one off here.

@taldcroft
Copy link
Member

taldcroft commented Dec 22, 2023

This is one case where keeping the commits separate (instead of squashing) is important.

@jeanconn jeanconn merged commit d578fd0 into master Dec 22, 2023
@jeanconn jeanconn deleted the ocat-ds10.12.3 branch December 22, 2023 14:32
@javierggt javierggt mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants