Add fid offset support

[jeanconn]

Description

Moves "expected" position of fid lights to be their positions with chandra_aca.drift.get_fid_offset applied.

The expected positions are used to check if there is a commanded ON fid light within fid-light-search-hw of th expected position and to check if there is a fid light in an acquisition box

This also removes < -14C warning (which was a proxy for fid position).

Interface impacts

Testing

Unit tests

• Mac

Independent check of unit tests by [REVIEWER NAME]

• [PLATFORM]:

Functional tests

Output in https://icxc.cfa.harvard.edu/aspect/test_review_outputs/starcheck/starcheck-pr431/

sandbox_starcheck run out of ska3-masters

/home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2022/NOV2122/oflsa/ -out nov2122a_25hw # with 25hw box artificially set on Obsid.pm
/home/jeanconn/git/starcheck/sandbox_starcheck -dir /data/mpcrit1/mplogs/2022/NOV2122/oflsa/ -out nov2122a_40hw # with 40hw box (PR value)
/proj/sot/ska3/flight/bin/skare starcheck -dir /data/mpcrit1/mplogs/2022/NOV2122/oflsa/ -out nov2122a_flight
diff nov2122a_40hw.txt nov2122a_flight.txt > nov2122a_diff.txt
/proj/sot/ska/bin/diff2html nov2122a_flight.txt nov2122a_40hw.txt > nov2122a_diff.html

[taldcroft]

This looks good with just a couple of minor comments and removing the sanity check. We could ask Matt but I'm reasonably confident the CCD model settling temperature is well above -20C everywhere and somewhat below +5C everywhere for at least the next year. So this check basically cannot be triggered.

[jeanconn]

Functional tests rerun at c354581 .

[taldcroft]

Looks good now!