Loopback interface configuration CLIs #879

preetham-singh · 2020-04-16T01:55:42Z

- What I did
Adding Configuration CLI to create loopback interfaces
Adding Show cli: show interfaces loopback to print list of loopback interfaces created with VRF binding information from config-db.

Examples:

admin@sonic:~$ sudo config loopback add Loopback11

admin@sonic:~$ show interfaces loopback
Name         VRF
-----        -------
Loopback0           
Loopback11
Loopback100  Vrf-10 
Loopback101         
Loopback102  Vrf-10

config interface vrf bind Loopback11 Vrf-11

admin@sonic:~$ show interfaces loopback
Name         VRF
-----        -------
Loopback0           
Loopback11   Vrf-11 
Loopback100  Vrf-10 
Loopback101         
Loopback102  Vrf-10

- How I did it

- How to verify it

Create Loopback using:
config loopback add Loopback
config loopback del Loopback where id is loopback id in range <0-999>
show interfaces loopback [Loopback] [--verbose] Prints loopback interfaces configured by user by fetching information from config-db. If --verbose option provided, it prints IP configured on corresponding Loopback interface by fetching information from config-db.

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

lgtm-com · 2020-04-16T02:02:17Z

This pull request introduces 1 alert when merging 6b08911f8ba54d50b6220e1a7d1242453299c115 into 3f651dc - view on LGTM.com

new alerts:

1 for Unnecessary pass

lgtm-com · 2020-04-16T02:34:13Z

This pull request introduces 1 alert when merging a9495b43c67db1bd38f477ded18c1269821f3666 into 3f651dc - view on LGTM.com

new alerts:

1 for Unnecessary pass

jleveque · 2020-04-20T19:46:22Z

@preetham-singh: Please fix LGTM alert.

prsunny · 2020-04-24T18:33:28Z

@preetham-singh, can you resolve conflict? Also could you provide the show command output in description for the commands you introduced? You can refer - #880

configured

from linux subsystem.

Updating Loopback creation CLI to only create loopback interface and not perform vrf bind to be inline with other interface vrf binding.

preetham-singh · 2020-04-25T04:28:09Z

@preetham-singh, can you resolve conflict? Also could you provide the show command output in description for the commands you introduced? You can refer - #880

Thanks @prsunny . I have resolved conflicts and updated the commit with show output examples.

show/main.py

prsunny · 2020-04-30T21:00:41Z

doc/Command-Reference.md

-  eth0           10.3.147.252/23      up/up         N/A             N/A
-  lo             127.0.0.1/8          up/up         N/A             N/A
+  Interface      IPv4 address/mask    Master        Admin/Oper      BGP Neighbor     Neighbor IP     Flags
+  -------------  -------------------  ------------  --------------  -------------    -------------   -------


I see that Master is second column - ref . I don't see a code change. Please correct the output

prsunny · 2020-04-30T21:01:54Z

doc/Command-Reference.md

-  Vlan100        fe80::eef4:bbff:fefe:880a%Vlan100/64      up/up         N/A             N/A
-  eth0           fe80::eef4:bbff:fefe:880a%eth0/64         up/up         N/A             N/A
-  lo             fc00:1::32/128                            up/up         N/A             N/A
+  Interface      IPv6 address/mask                         Master    Admin/Oper    BGP Neighbor    Neighbor IP


Same as above

show/main.py

prsunny · 2020-04-30T21:09:09Z

show/main.py

+# 'show interfaces loopback' group command
+#
+#
+@interfaces.command()


I'm not sure if we want to have this command output. IMO, all of this is available in show ip interfaces. show interfaces is mostly the Layer 2 info. I think this command is redundant. What do you think?

There was a internal request to add command to list loopback interfaces created since show ip interface would show only if IP was assigned. Hence we planned to add this command. If this is not necessary I can remove this command and update. Please let me know.

IMO, it is better to avoid any duplicates. This file is already pretty big. Could you please remove this command since in most cases, loopback will be assigned with an IP address?

prsunny · 2020-04-30T21:09:21Z

show/main.py

+        for lo in natsorted(loopbacks):
+            if type(lo) == tuple:
+                continue
+            intf_vrf = get_intf_master(lo)


Please use get_if_master

- This flag is currently no functional impact with just this change. - This flag is intended to coordinate fast-reboot shutdown path. - This flag enables moving fast-reboot per service knowledge to service scripts. which unblocks moving warm-reboot per service knowledge to service scripts. - This flag is consistent with the bootup flag we setting on the boot up path. Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* [utility] Filter FDB entries FDB table can get large due to VM creation/deletion which cause fast reboot to slow down. This utility fitlers FDB entries based on current MAC entries in the ARP table. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>

…ot user (#872) Removed user privileges checks. These changes fix #800. The ZTP PR sonic-net/sonic-ztp#13 is also required for these changes to work as expected. ``` admin@sonic:~$ show ztp status ZTP Admin Mode : True ZTP Service : Processing ZTP Status : IN-PROGRESS ZTP Source : local-fs (/host/ztp/ztp_data_local.json) Runtime : 06m 26s Timestamp : 2020-04-08 13:08:22 UTC ZTP Service is active 01-test-plugin: IN-PROGRESS ``` Signed-off-by: Rajendra Dendukuri <rajendra.dendukuri@broadcom.com>

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* ssd_mitigation_changes * ssd_mitigation_changes * ssd_mitigation_changes

…s output (#886)

* Changes: 1) Add syslog support. 2) Enable forever periodic scan 3) Skip link local addresses 4) Skip eth0 routes 3) Adopt to 20191130 changes 3.1) APPl-DB INTF_TABLE may not have IP address 3.2) nexthop is never empty * No logical code change. A small name change. * 1) Adopt to 201811 -- Filter out 'lo' & 'docker0' in addition to 'eth0' as local routes 2) Ensure to read route entry w/o prefix, if not present with prefix

* [Phase 1] Multi ASIC config command changes, db_mgrator.py script updates for handing namespace. * Fixes and comment updates * Comments addressed + added support for user to input the config files per namespace also. * Updates per comments + based on the updated SonicV2Connector/ConfigDBConnector class design * Review comments update. * Help string updated for config save/reload/load

* Fix NameError for 'swsssdk', align neig output

- Modify the load_minigraph command handler to support multi NPU platforms

…ers' group (#900) Co-authored-by: Travis Van Duyn <trvanduy@microsoft.com>

…t' subcommands (#904)

Signed-off-by: yangshiping <yangshiping@jd.com>

output. Reusing existing get_intf_master to get vrf binding for the interface

prsunny · 2020-05-12T22:31:10Z

can you do a rebase?

- Modify the load_minigraph command handler to support multi NPU platforms

preetham-singh · 2020-05-18T05:28:52Z

can you do a rebase?

Done

prsunny · 2020-05-18T18:14:39Z

@preetham-singh , can you update the description as there is no new show CLI

* Adding configuration CLIs for loopback interfaces

jleveque requested a review from prsunny April 20, 2020 19:46

jleveque added the Enhancement label Apr 20, 2020

preetham-singh added 5 commits April 24, 2020 17:41

Adding configuration CLIs for loopback interfaces

4fb95be

Adding show interface loopback CLI to dump list of loopback interfaces

e28fc6f

configured

Adding missing get_intf_master to get interface vrf binding information

297f78d

from linux subsystem.

Updating Command reference guide to include Vrf & Loopback CLIs

51b43f0

Updating Loopback creation CLI to only create loopback interface and not perform vrf bind to be inline with other interface vrf binding.

Fixing LGTM alert by removing unnecessary pass

c2c08b7

prsunny reviewed Apr 30, 2020

View reviewed changes

yxieca and others added 17 commits May 12, 2020 10:08

[doc]: ZTP configuration and show commands (#866)

4d29a3c

[fwutil]: Fix firmware update command. (#895)

506a407

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

Make config command support abbreviation. (#893)

f78755c

ssd_mitigation_changes (#829)

726da60

* ssd_mitigation_changes * ssd_mitigation_changes * ssd_mitigation_changes

[psushow] Add a column to display LED color to show platform psustatu…

9060054

…s output (#886)

[show] Fix abbreviations for 'show ip bgp ...' commands (#901)

72f8713

[Vnet] Fix NameError for 'swsssdk' and align output (#902)

e9b79dc

* Fix NameError for 'swsssdk', align neig output

[config] Support load_minigraph command for multi NPU platform (#896)

52ac15a

- Modify the load_minigraph command handler to support multi NPU platforms

[show] Add 'errors' and 'rates' subcommands to 'show interfaces count…

188aaf9

…ers' group (#900) Co-authored-by: Travis Van Duyn <trvanduy@microsoft.com>

[config] Add 'interface transceiver' subgroup with 'lpmode' and 'rese…

47c7b3b

…t' subcommands (#904)

Remove dependency on click-default-group package (#903)

e0eff2d

[config] Log invocation of config commands to syslog (#259)

0a283ae

yangshp1987 and others added 3 commits May 12, 2020 10:10

[show] Add ntpstat output to show ntp (#861)

d625d06

Signed-off-by: yangshiping <yangshiping@jd.com>

Adding configuration CLIs for loopback interfaces

a0ec639

Updating CLI Command reference guide with correct show ip interface

06ef536

output. Reusing existing get_intf_master to get vrf binding for the interface

preetham-singh and others added 5 commits May 13, 2020 15:51

Merge branch 'master' into master

43b274e

Adding configuration CLIs for loopback interfaces

b6a528c

Make config command support abbreviation. (#893)

680eb43

[config] Support load_minigraph command for multi NPU platform (#896)

00b2d25

- Modify the load_minigraph command handler to support multi NPU platforms

Removing show interfaces loopback command as per review comment.

e516d0c

prsunny approved these changes May 18, 2020

View reviewed changes

preetham-singh changed the title ~~Loopback interface configuration and show CLIs~~ Loopback interface configuration CLIs May 19, 2020

prsunny merged commit 10c7ba1 into sonic-net:master May 21, 2020

abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020

Loopback interface configuration CLIs (sonic-net#879)

b3b444a

* Adding configuration CLIs for loopback interfaces

preetham-singh mentioned this pull request Aug 8, 2021

Adding Loopback interface per VRF support CLI #581

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Loopback interface configuration CLIs #879

Loopback interface configuration CLIs #879

preetham-singh commented Apr 16, 2020 •

edited

Loading

lgtm-com bot commented Apr 16, 2020

lgtm-com bot commented Apr 16, 2020

jleveque commented Apr 20, 2020

prsunny commented Apr 24, 2020

preetham-singh commented Apr 25, 2020

prsunny Apr 30, 2020

preetham-singh May 12, 2020

prsunny Apr 30, 2020

preetham-singh May 12, 2020

prsunny Apr 30, 2020

preetham-singh May 12, 2020

prsunny May 12, 2020

preetham-singh May 18, 2020

prsunny Apr 30, 2020

preetham-singh May 12, 2020

prsunny commented May 12, 2020

preetham-singh commented May 18, 2020

prsunny commented May 18, 2020

Loopback interface configuration CLIs #879

Loopback interface configuration CLIs #879

Conversation

preetham-singh commented Apr 16, 2020 • edited Loading

lgtm-com bot commented Apr 16, 2020

lgtm-com bot commented Apr 16, 2020

jleveque commented Apr 20, 2020

prsunny commented Apr 24, 2020

preetham-singh commented Apr 25, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prsunny commented May 12, 2020

preetham-singh commented May 18, 2020

prsunny commented May 18, 2020

preetham-singh commented Apr 16, 2020 •

edited

Loading