Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[psushow] Add a column to display LED color to show platform psustatus output #886

Merged
merged 2 commits into from
Apr 30, 2020
Merged

[psushow] Add a column to display LED color to show platform psustatus output #886

merged 2 commits into from
Apr 30, 2020

Conversation

Junchao-Mellanox
Copy link
Collaborator

- What I did

Add a column to display LED color to show platform psustatus output.

- How I did it

Add a column "LED", it will display PSU physical LED color in command line output.

- How to verify it

  1. Adjust existing unit test case
  2. Add/adjust test cases to sonic-mgmt
  3. Manual test

- Previous command output (if the output of a command-line utility has changed)

PSU    Status
-----  --------
PSU 1  OK
PSU 2  OK

- New command output (if the output of a command-line utility has changed)

PSU    Status    LED
-----  --------  -------
PSU 1  OK        green
PSU 2  OK        red

@Junchao-Mellanox Junchao-Mellanox marked this pull request as draft April 23, 2020 02:30
@Junchao-Mellanox Junchao-Mellanox mentioned this pull request Apr 24, 2020
Closed
@Junchao-Mellanox Junchao-Mellanox marked this pull request as ready for review April 24, 2020 10:41
@jleveque jleveque changed the title [Mellanox] Add a column to display LED color to show platform psustatus output [psushow] Add a column to display LED color to show platform psustatus output Apr 30, 2020
@jleveque jleveque merged commit 6fba8db into sonic-net:master Apr 30, 2020
@Junchao-Mellanox Junchao-Mellanox deleted the psu-led branch May 7, 2020 10:07
abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020
@Junchao-Mellanox @abdosi
[psushow] Add a column to display LED color to show platform psustatu…
660a287 
…s output (sonic-net#886)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Junchao-Mellanox @jleveque