Make config command support abbreviation
#893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Apr 29, 2020
jleveque
reviewed
Apr 29, 2020
| @@ -15,6 +15,7 @@ | |||
| from swsssdk import ConfigDBConnector | |||
| from swsssdk import SonicV2Connector | |||
| from minigraph import parse_device_desc_xml | |||
| from click_default_group import DefaultGroup | |||
There was a problem hiding this comment.
Is it necessary to import click_default_group to accomplish this? We don't use the functionality of DefaultGroup any longer, and I was planning to remove it entirely. Can instead inherit a Click class?
There was a problem hiding this comment.
DefaultGroup inherits from click.Group. Can you try simply inheriting this class and see if this works?
There was a problem hiding this comment.
We can merge this as-is and attempt to replace DefaultGroup with click.Group in a separate PR.
jleveque
approved these changes
Apr 29, 2020
|
@jleveque Please create PR for 201911. There are conflicts. |
jleveque
added a commit
that referenced
this pull request
Jun 8, 2020
Backport #893 to the 201911 branch to support abbreviation of `config` subcommands
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #532