[portsorch]: Update comments #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
lguohan
approved these changes
Oct 4, 2017
stcheng
pushed a commit
to stcheng/sonic-swss
that referenced
this pull request
Oct 5, 2017
This reverts commit f208eb7.
praveen-li
pushed a commit
to praveen-li/sonic-swss
that referenced
this pull request
Aug 24, 2020
* msft_github/master: [portsorch]: Use sai_serialize api to write to DB (sonic-net#331) [portsorch]: Update comments (sonic-net#333) [switchorch]: Add support of ECMP and LAG hash seed attribute (sonic-net#324) [portsorch]: Add support of cable breakout feature (sonic-net#320)
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* Added argument forwarder for platform reboot. * Removed code duplication.
lukasstockner
pushed a commit
to genesiscloud/sonic-swss
that referenced
this pull request
Apr 2, 2023
…d in the eepromTlvInfo decode (sonic-net#333) Description The VEMDOR_EXT field parse the data and format each in byte in hex with space as separator. But the logic leaves a space at the end of the value. This PR removes the trailing space in output of the VENDOR_EXT field in the eepromTlvInfo decode This change is needed by 202205 branch Motivation and Context The trailing space at end of the VENDOR_EXT field cause the test of function get_system_eeprom_info() failed. The trailing space of the data filed is invisible char in the show platform syseeprom output while the get_system_eeprom_info() return a dictionary with trailing space in the end. This results in a mis-matched in the test case. Signed-off-by: mlok <marty.lok@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shu0T1an ChenG shuche@microsoft.com