[portsorch]: Add support of cable breakout feature #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
|
@nikos-li do you have some concerns about this pull request? Let's discuss them here. |
stcheng
approved these changes
Oct 3, 2017
lguohan
reviewed
Oct 4, 2017
| p.m_index = static_cast<int32_t>(m_portList.size()); // TODO: Assume no deletion of physical port | ||
| p.m_port_id = id; | ||
|
|
||
| /* Initialize the port and create router interface and host interface */ |
There was a problem hiding this comment.
create router interface [](start = 39, length = 23)
this comment here is actualy incorrect, the initializePort no longer crate router interface.
praveen-li
pushed a commit
to praveen-li/sonic-swss
that referenced
this pull request
Aug 24, 2020
* msft_github/master: [portsorch]: Use sai_serialize api to write to DB (sonic-net#331) [portsorch]: Update comments (sonic-net#333) [switchorch]: Add support of ECMP and LAG hash seed attribute (sonic-net#324) [portsorch]: Add support of cable breakout feature (sonic-net#320)
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
lukasstockner
pushed a commit
to genesiscloud/sonic-swss
that referenced
this pull request
Apr 2, 2023
- Description For cmis cable, tx power and rx power is not rounding as other eeprom fields - Motivation and Context Fix issue: rounding float value for txpower and rxpower - How Has This Been Tested? Manual test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volodymyr Samotiy volodymyrs@mellanox.com