[switchorch]: Add support of ECMP and LAG hash seed attribute #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcheng
suggested changes
Sep 27, 2017
orchagent/switchorch.cpp
Outdated
|
|
||
| if (switch_attribute_map.find(attribute) == switch_attribute_map.end()) | ||
| if (fvField(i) == "hash_seed") |
There was a problem hiding this comment.
i wonder if we don't need such logics here. if we would like to set the two values with the same value, it is okay that we feed the swssconfig with the JSON file that contains both attributes with the same value. Thus the for loop below is not necessary.
There was a problem hiding this comment.
I agree that it would be better and logical to set hash seed attributes separately. I will update the pull request with appropriate changes.
Since changes were done according to requirements document, I believe it should be updated as well. (https://github.com/Azure/SONiC/wiki/ECMP-and-LAG-Hash-Seed)
lguohan
reviewed
Oct 2, 2017
orchagent/switchorch.cpp
Outdated
| @@ -12,7 +13,9 @@ const map<string, sai_switch_attr_t> switch_attribute_map = | |||
| { | |||
| {"fdb_unicast_miss_packet_action", SAI_SWITCH_ATTR_FDB_UNICAST_MISS_PACKET_ACTION}, | |||
| {"fdb_broadcast_miss_packet_action", SAI_SWITCH_ATTR_FDB_BROADCAST_MISS_PACKET_ACTION}, | |||
| {"fdb_multicast_miss_packet_action", SAI_SWITCH_ATTR_FDB_MULTICAST_MISS_PACKET_ACTION} | |||
| {"fdb_multicast_miss_packet_action", SAI_SWITCH_ATTR_FDB_MULTICAST_MISS_PACKET_ACTION}, | |||
| {"ecmp_default_hash_seed", SAI_SWITCH_ATTR_ECMP_DEFAULT_HASH_SEED}, | |||
There was a problem hiding this comment.
agree. default shall not be in the attribute name. default is a value not an attribute. the SAI attribute name is not perfect.
lguohan
reviewed
Oct 2, 2017
orchagent/switchorch.cpp
Outdated
| {"fdb_multicast_miss_packet_action", SAI_SWITCH_ATTR_FDB_MULTICAST_MISS_PACKET_ACTION} | ||
| {"fdb_multicast_miss_packet_action", SAI_SWITCH_ATTR_FDB_MULTICAST_MISS_PACKET_ACTION}, | ||
| {"ecmp_default_hash_seed", SAI_SWITCH_ATTR_ECMP_DEFAULT_HASH_SEED}, | ||
| {"lag_default_hash_seed", SAI_SWITCH_ATTR_LAG_DEFAULT_HASH_SEED} |
lguohan
reviewed
Oct 2, 2017
|
|
||
| case SAI_SWITCH_ATTR_ECMP_DEFAULT_HASH_SEED: | ||
| case SAI_SWITCH_ATTR_LAG_DEFAULT_HASH_SEED: | ||
| attr.value.u32 = to_uint<uint32_t>(value); |
There was a problem hiding this comment.
do we have test cases for different hash seeds?
There was a problem hiding this comment.
No, as far as I know, we don't have.
Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
stcheng
approved these changes
Oct 3, 2017
stcheng
approved these changes
Oct 3, 2017
praveen-li
pushed a commit
to praveen-li/sonic-swss
that referenced
this pull request
Aug 24, 2020
* msft_github/master: [portsorch]: Use sai_serialize api to write to DB (sonic-net#331) [portsorch]: Update comments (sonic-net#333) [switchorch]: Add support of ECMP and LAG hash seed attribute (sonic-net#324) [portsorch]: Add support of cable breakout feature (sonic-net#320)
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…tem info on device (sonic-net#324) The information includes: -- platform string -- system mac -- port configuration: alias, lanes, speed, index This is useful when we first load the configuration from config_db.json generated outside which does not have the information on the device. The default behaviour is not changed, so it won't impact the system unless you use this option. This can be used for ZTP to config the box the first time and avoid any addtional work which could cause inconsistency.
lukasstockner
pushed a commit
to genesiscloud/sonic-swss
that referenced
this pull request
Apr 2, 2023
…onic-net#324) (sonic-net#329) - Description Add media assignment options to Application Advertisement - Motivation and Context Add media assignment options to Application Advertisement - How Has This Been Tested? Manual test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volodymyr Samotiy volodymyrs@mellanox.com