Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gNOI Warm Reboot - rebootbackend changes #20786

Merged
merged 5 commits into from
Mar 12, 2025

Conversation

rkavitha-hcl
Copy link
Contributor

@rkavitha-hcl rkavitha-hcl commented Nov 13, 2024

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Enabled Rebootbackend to support gNOI Warm Reboot.
Adding HALT method support in sonic-buildimage.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_wr_PR1 branch 2 times, most recently from ba55f24 to d734d22 Compare November 15, 2024 12:30
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_wr_PR1 branch 4 times, most recently from c07b6ce to 8a75037 Compare November 26, 2024 10:57
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_wr_PR1 branch 7 times, most recently from 50d08e6 to 383cb08 Compare December 4, 2024 06:58
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_wr_PR1 branch 2 times, most recently from 8fdbd07 to ec885af Compare December 5, 2024 10:07
@kishanps
Copy link

kishanps commented Dec 6, 2024

@github76543 Joh, can you PTAL and signoff.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Pull request contains merge conflicts.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Pull request contains merge conflicts.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vvolam
Copy link
Contributor

vvolam commented Mar 10, 2025

/azpw run

Copy link
Contributor

@vvolam vvolam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@vvolam
Copy link
Contributor

vvolam commented Mar 10, 2025

/azp run Azure.sonic-buildimage

Copy link

Commenter does not have sufficient privileges for PR 20786 in repo sonic-net/sonic-buildimage

@qiluo-msft
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vvolam
Copy link
Contributor

vvolam commented Mar 11, 2025

@rkavitha-hcl Please don't do force pushes in future as it is really hard to track reviewed changes and new commits. Please add commits on top for new changes. Thank you!

url = https://github.com/sonic-net/sonic-platform-vpp.git
[submodule "src/sonic-framework/gnoi"]
path = src/sonic-framework/gnoi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern is the name "sonic-framework" too general. Please fix in future PR.

@qiluo-msft qiluo-msft merged commit 46eb26e into sonic-net:master Mar 12, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants