-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gNOI Warm Reboot - rebootbackend changes #20786
Conversation
ba55f24
to
d734d22
Compare
c07b6ce
to
8a75037
Compare
50d08e6
to
383cb08
Compare
8fdbd07
to
ec885af
Compare
@github76543 Joh, can you PTAL and signoff. |
566b7c8
to
292827c
Compare
292827c
to
fb77fb5
Compare
/azp run Azure.sonic-buildimage |
Pull request contains merge conflicts. |
fb77fb5
to
0c257c3
Compare
/azp run Azure.sonic-buildimage |
Pull request contains merge conflicts. |
b3b5c41
to
6d697d5
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
6d697d5
to
8428f4e
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
8428f4e
to
de39fc7
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
de39fc7
to
8c7248a
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
…ebootbackend process
8c7248a
to
9fc0c1e
Compare
/azpw run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you!
/azp run Azure.sonic-buildimage |
Commenter does not have sufficient privileges for PR 20786 in repo sonic-net/sonic-buildimage |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@rkavitha-hcl Please don't do force pushes in future as it is really hard to track reviewed changes and new commits. Please add commits on top for new changes. Thank you! |
url = https://github.com/sonic-net/sonic-platform-vpp.git | ||
[submodule "src/sonic-framework/gnoi"] | ||
path = src/sonic-framework/gnoi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern is the name "sonic-framework" too general. Please fix in future PR.
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Enabled Rebootbackend to support gNOI Warm Reboot.
Adding HALT method support in sonic-buildimage.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)