Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gNOI Cold Reboot - Integrated Docker and Makefile changes #20713

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

gNOI Cold Reboot - Integrated Docker and Makefile changes #20713

wants to merge 6 commits into from
+2,761 −3

Conversation

rkavitha-hcl
Copy link
Contributor

@rkavitha-hcl rkavitha-hcl commented Nov 6, 2024 •
edited
Loading

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

  1. Code changes are tested on Sonic virtual switch.
  2. Triggered Cold reboot , Warm reboot and Halt reboot using gnmi gnoi_client command with reboot messages on sonic-vs to test the reboots.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

  1. Added code for listing out the dependent packages and the version inside the framework docker.
  2. Added the list of binaries to be started inside the framework docker when it is started
  3. Added Makefiles for framework module and tests

framework is the container inside which rebootbackend process runs. It receives the Cold/Warm/Halt reboot requests from gNOI and services it.
This container is disabled by default. It can be enabled or disabled using following sonic-cli.

sudo config feature state framework enabled
sudo config feature state framework disabled
sudo config save -y

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@vvolam
Copy link
Contributor

vvolam commented Nov 7, 2024

Bookworm compatibility Makefiles seems to be missing. could you please add them?

@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_cr_PR5 branch 6 times, most recently from 8f64ce2 to 02b4273 Compare November 21, 2024 06:26
@rkavitha-hcl rkavitha-hcl mentioned this pull request Nov 21, 2024
Open
11 tasks
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_cr_PR5 branch 2 times, most recently from e784820 to 624101c Compare November 21, 2024 12:31
@rkavitha-hcl
Copy link
Contributor Author

Bookworm compatibility Makefiles seems to be missing. could you please add them?

Added support for Bookworm

@hdwhdw hdwhdw self-requested a review November 22, 2024 16:37
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_cr_PR5 branch 3 times, most recently from 1856421 to 3887d65 Compare November 28, 2024 10:06
@rkavitha-hcl rkavitha-hcl mentioned this pull request Nov 28, 2024
Open
11 tasks
@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_cr_PR5 branch 3 times, most recently from c6fddf0 to f21b38d Compare December 4, 2024 14:58
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 11, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@rkavitha-hcl rkavitha-hcl force-pushed the gnoi_cr_PR5 branch 3 times, most recently from f934703 to aa12d7f Compare December 12, 2024 06:53
@rkavitha-hcl rkavitha-hcl mentioned this pull request Dec 12, 2024
Open
11 tasks
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vvolam
Copy link
Contributor

vvolam commented Mar 10, 2025

@bibhuprasad-hcl, @rkavitha-hcl Could you update the PR decription clearly on the functionality of the framework container that is being added?

vvolam
vvolam reviewed Mar 11, 2025
View reviewed changes
files/build/versions/dockers/docker-framework/versions-deb-bookworm
framework==1.0.0
framework-dbg==1.0.0
gcc-10-base==10.2.1-6
gcc-9-base==9.3.0-22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need 2 gcc versions?

files/build/versions/dockers/docker-sonic-vs/versions-deb-bookworm
@@ -14,6 +14,7 @@ dirmngr==2.2.40-1.1
ethtool==1:6.1-1
fontconfig-config==2.14.1-4
fonts-dejavu-core==2.37-6
framework==1.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A generic question, what is the maximum memory and CPU consumption by this new container?
And is it continuous usage or only when handling reboot request?

Copy link

@bibhuprasad-hcl bibhuprasad-hcl Mar 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A generic question, what is the maximum memory and CPU consumption by this new container? And is it continuous usage or only when handling reboot request?

framework container can be disabled/enabled using sonic-cli.
Attaching the memory and CPU consumption stats by framework-container when it is enabled in Sonic-VS.

root@sonic:/home/admin# docker stats framework
CONTAINER ID NAME CPU % MEM USAGE / LIMIT MEM % NET I/O BLOCK I/O PIDS
f439b1116aaa framework 0.01% 37.34MiB / 3.663GiB 1.00% 0B / 0B 0B / 0B 10

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vvolam To add, in steady state, the rebootbackend process only listens for redis db notification and then start a thread to orchestrate the reboot process. So, there should be not much of an impact to cpu or memory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kishanps Got it. Thanks

@vvolam
Copy link
Contributor

vvolam commented Mar 12, 2025

@bibhuprasad-hcl Could you please merge the latest changes from sonic-build image as other commits got merged. Also could you remove changes from protected files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishanps kishanps kishanps left review comments

@bibhuprasad-hcl bibhuprasad-hcl bibhuprasad-hcl left review comments

@vvolam vvolam vvolam left review comments

@hdwhdw hdwhdw hdwhdw approved these changes

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft qiluo-msft is a code owner

@xumia xumia Awaiting requested review from xumia xumia is a code owner

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rkavitha-hcl @vvolam @mssonicbld @bibhuprasad-hcl @hdwhdw @kishanps