Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ merge next into main #1785

Merged
merged 52 commits into from
Jan 16, 2025
Merged

feat: ✨ merge next into main #1785

merged 52 commits into from
Jan 16, 2025

Conversation

mariohamann
Copy link
Contributor

No description provided.

smfonseca and others added 30 commits December 16, 2024 14:05
@smfonseca
chore: cleanup docs changelog (#1736)
321b929 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
This PR is meant to cleanup the docs changelog which contains test
entries. It also sets the package to its correct version.

## Definition of Reviewable:
<!-- *PR notes: Irrelevant elements should be removed.* -->
- [ ] Documentation is created/updated
- [ ] Migration Guide is created/updated
- [ ] E2E tests (features, a11y, bug fixes) are created/updated
<!-- *If this PR includes a bug fix, an E2E test is necessary to verify
the change. If the fix is purely visual, ensuring it is captured within
our chromatic screenshot tests is sufficient.* -->
- [ ] Stories (features, a11y) are created/updated
- [ ] relevant tickets are linked
@smfonseca
fix: sd-interactive a11y (#1740)
311d2f6 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
<!-- *PR notes: Please describe the changes in this PR.* -->

## Definition of Reviewable:
<!-- *PR notes: Irrelevant elements should be removed.* -->
- [ ] Documentation is created/updated
- [ ] Migration Guide is created/updated
- [ ] E2E tests (features, a11y, bug fixes) are created/updated
<!-- *If this PR includes a bug fix, an E2E test is necessary to verify
the change. If the fix is purely visual, ensuring it is captured within
our chromatic screenshot tests is sufficient.* -->
- [ ] Stories (features, a11y) are created/updated
- [ ] relevant tickets are linked
@github-actions
chore(release-next): docs@1.2.7-next.0
e15df50
@mariohamann
chore: fix prettier & eslint
74e9a41
@mariohamann
feat: ✨ architecture rewrite and breaking changes (#1689)
4c065bd
@github-actions
chore(release-next): components@4.0.0-next.0, docs@1.2.7-next.1
b286829
@mariohamann
chore: init styles
6b9a71e
@mariohamann
chore: fix pipelines
28a811d
@mariohamann
chore: fix postversion script in styles
0777ae0
@github-actions
chore(release-next): styles@1.0.0-next.0
8bf5288
@mariohamann
chore: fix ci... again
a6a5495
@mariohamann
chore: fix URLs in Storybook Codepens in different environments (#1749)
dee4112
@github-actions
chore(release-next): docs@1.3.0-next.2
b79a45f
@mariohamann
chore: fix component urls
a53befe
@mariohamann
fix other urls
ef32452
@paulovareiro29 @mariohamann
fix: improve sd-teaser a11y (#1748)
5a8c80f 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
Closes #1502

This PR addresses:
- Reordering of DOM elements so headline is read first on `sd-teaser`

## Definition of Reviewable:
<!-- *PR notes: Irrelevant elements should be removed.* -->
- [x] Documentation is created/updated
- [x] relevant tickets are linked

---------

Co-authored-by: Mario Hamann <mario.hamann@virtual-identity.com>
@github-actions
chore(release-next): components@4.0.0-next.1
54b9f8c
@smfonseca
chore: add changeset to publish styles package (#1750)
c6ab1b4 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
This PR is meant to corrrectly publish the styles package into npm.

## Definition of Reviewable:
<!-- *PR notes: Irrelevant elements should be removed.* -->
- [ ] Documentation is created/updated
- [ ] Migration Guide is created/updated
- [ ] E2E tests (features, a11y, bug fixes) are created/updated
<!-- *If this PR includes a bug fix, an E2E test is necessary to verify
the change. If the fix is purely visual, ensuring it is captured within
our chromatic screenshot tests is sufficient.* -->
- [ ] Stories (features, a11y) are created/updated
- [ ] relevant tickets are linked
@github-actions
chore(release-next): styles@1.0.0-next.1
e2d6358
@paulovareiro29
fix: improve sd-divider a11y (#1751)
f0fd5cb 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
Closes #1497 

This PR addresses:
- Implement `aria-orientation` on sd-divider

## Definition of Reviewable:
- [x] E2E tests (features, a11y, bug fixes) are created/updated
- [x] relevant tickets are linked
@github-actions
chore(release-next): components@4.0.0-next.2
3ff42ed
@paulovareiro29
fix: improve sd-accordion and sd-quickfact a11y (#1757)
b83d804 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
Closes #1496 #1500

This PR addresses:
- Adapt sd-accordion HTML using `details` and `summary` elements
- Adapt expandable sd-quickfact HTML using `details` and `summary`
elements

## Definition of Reviewable:
<!-- *PR notes: Irrelevant elements should be removed.* -->
- [x] relevant tickets are linked
@github-actions
chore(release-next): components@4.0.0-next.3
35c9ac6
@paulovareiro29
fix: sd-tab broken padding-right (#1755)
9954447 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
Closes #1709 

## Definition of Reviewable:
- [x] Documentation is created/updated
- [x] relevant tickets are linked
@github-actions
chore(release-next): components@4.0.0-next.4, docs@1.3.0-next.3
4553eee
@mariohamann
fix: fix disconnecedCallback in sd-tab-group (#1768)
fbf375e
@github-actions
chore(release-next): components@4.0.0-next.5
74774f1
@paulovareiro29
fix: improve sd-flipcard hidden side a11y (#1760)
a64a5ba 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
Closes #1477

## Definition of Reviewable:
- [x] E2E tests (features, a11y, bug fixes) are created/updated
- [x] relevant tickets are linked
@github-actions
chore(release-next): components@4.0.0-next.6
ff7b97d
@paulovareiro29
fix: sd-hidden-links screenshot tests (#1753)
5dbc65f 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
Closes #1505 

This PR addresses:
- sd-hidden-links behind header due to z-index issue on screenshot test.
- added debug attribute to show sd-hidden-links on screenshot test.

## Definition of Reviewable:
- [x] Stories (features, a11y) are created/updated
- [x] relevant tickets are linked
github-actions bot and others added 20 commits January 13, 2025 15:53
@github-actions
chore(release-next): docs@1.3.0-next.4
9a46979
@DanielHargesheimer
fix: sd-combobox and sd-select (#1742)
125d5f1
@github-actions
chore(release-next): components@4.0.0-next.7, docs@1.3.0-next.5
0529efd
@smfonseca @mariohamann
fix: reactive translations (#1761)
6b544f5 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
This PR addresses the missing translation of the input placeholder in
the sd-select and sd-combobox components and closes
[#998](#998)

## Definition of Reviewable:
<!-- *PR notes: Irrelevant elements should be removed.* -->
- [ ] Documentation is created/updated
- [ ] Migration Guide is created/updated
- [x] E2E tests (features, a11y, bug fixes) are created/updated
<!-- *If this PR includes a bug fix, an E2E test is necessary to verify
the change. If the fix is purely visual, ensuring it is captured within
our chromatic screenshot tests is sufficient.* -->
- [ ] Stories (features, a11y) are created/updated
- [ ] relevant tickets are linked

---------

Co-authored-by: Mario Hamann <mario.hamann@virtual-identity.com>
@github-actions
chore(release-next): components@4.0.0-next.8
2c2308e
@smfonseca
fix: combobox tests (#1775)
0a73372 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
This PR addresses a failing test in the combobox placeholder text.

## Definition of Reviewable:
<!-- *PR notes: Irrelevant elements should be removed.* -->
- [ ] Documentation is created/updated
- [ ] Migration Guide is created/updated
- [x] E2E tests (features, a11y, bug fixes) are created/updated
<!-- *If this PR includes a bug fix, an E2E test is necessary to verify
the change. If the fix is purely visual, ensuring it is captured within
our chromatic screenshot tests is sufficient.* -->
- [ ] Stories (features, a11y) are created/updated
- [ ] relevant tickets are linked
@smfonseca
feat: sd-badge variants naming (#1774)
8b96338 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
The PR contains breaking changes. The sd-badge variant attribute options
have been renamed to remove any semantic meaning from them. Closes
[#1593 ](#1593)

## Definition of Reviewable:
<!-- *PR notes: Irrelevant elements should be removed.* -->
- [ ] Documentation is created/updated
- [x] Migration Guide is created/updated
- [x] E2E tests (features, a11y, bug fixes) are created/updated
<!-- *If this PR includes a bug fix, an E2E test is necessary to verify
the change. If the fix is purely visual, ensuring it is captured within
our chromatic screenshot tests is sufficient.* -->
- [ ] Stories (features, a11y) are created/updated
- [ ] relevant tickets are linked
@github-actions
chore(release-next): components@4.0.0-next.9, docs@1.3.0-next.6
03dc24b
@paulovareiro29
chore!: remove sd-video overlay feature (#1776)
d12e330 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
<!-- *PR notes: Please describe the changes in this PR.* -->
Closes #1665

## Definition of Reviewable:
<!-- *PR notes: Irrelevant elements should be removed.* -->
- [x] Documentation is created/updated
- [x] Migration Guide is created/updated
- [x] E2E tests (features, a11y, bug fixes) are created/updated
<!-- *If this PR includes a bug fix, an E2E test is necessary to verify
the change. If the fix is purely visual, ensuring it is captured within
our chromatic screenshot tests is sufficient.* -->
- [x] Stories (features, a11y) are created/updated
- [x] relevant tickets are linked
@github-actions
chore(release-next): components@4.0.0-next.10, docs@1.3.0-next.7
c7d9194
@paulovareiro29 @mariohamann
fix: update flipcard template (#1752)
1f05b67 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
Closes #1518  

This PR addresses:
- Fixed issue with gradients on flipcard (noticed it when creating the
template)
- Implement flipcard template according to design

## Definition of Reviewable:
- [x] Stories (features, a11y) are created/updated
- [x] relevant tickets are linked

---------

Co-authored-by: Mario Hamann <mario.hamann@virtual-identity.com>
@github-actions
chore(release-next): components@4.0.0-next.11, docs@1.3.0-next.8
38581d8
@paulovareiro29
fix: sd-select default scrollbar (#1769)
49615f2 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
Closes #1318

This PR addresses:
- sd-select default scrollbar appearing by default, even when unecessary

## Definition of Reviewable:
- [x] relevant tickets are linked
@github-actions
chore(release-next): docs@1.3.0-next.9
0450b79
@paulovareiro29 @mariohamann
fix: improve sd-expandable a11y (#1724)
c7bab9d 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
Closes #1476 and #1778

This PR addresses:
- Adjust sd-expandable spacings according to figma
- Reorder of sd-expandable dom order. (button first so it is targetable
by keyboard first)
- Improvement of the sd-expandable template labels
- Added accessibility hints to sd-expandable

## Definition of Reviewable:
<!-- *PR notes: Irrelevant elements should be removed.* -->
- [x] Documentation is created/updated
- [ ] Migration Guide is created/updated
- [ ] E2E tests (features, a11y, bug fixes) are created/updated
<!-- *If this PR includes a bug fix, an E2E test is necessary to verify
the change. If the fix is purely visual, ensuring it is captured within
our chromatic screenshot tests is sufficient.* -->
- [x] Stories (features, a11y) are created/updated
- [x] relevant tickets are linked

---------

Co-authored-by: Mario Hamann <mario.hamann@virtual-identity.com>
@github-actions
chore(release-next): components@4.0.0-next.12, docs@1.3.0-next.10
bb36946
@paulovareiro29
fix: improve quote template a11y (#1756)
70a17a0 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
<!-- *PR notes: Please describe the changes in this PR.* -->
Closes #1511

This PR addresses:
- Fix quote template a11y
- Add accessibility hint on quote template
- Add "profile" placeholder image

## Definition of Reviewable:
- [x] Stories (features, a11y) are created/updated
- [x] relevant tickets are linked
@github-actions
chore(release-next): docs@1.3.0-next.11, placeholders@2.1.0-next.0
d58dea8
@paulovareiro29
fix: improve sd-headline a11y (#1729)
776ed57 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
Closes #1504

This PR addresses:
- [x] Default story headline changed to `h2`.
- [x] Rephrase sd-headline stories description to explain why semantics
and styles are disconnected
- [x] Add a template to show real life examples from disconnected
headlines

## Definition of Reviewable:
<!-- *PR notes: Irrelevant elements should be removed.* -->
- [x] Documentation is created/updated
- [x] Stories (features, a11y) are created/updated
- [x] relevant tickets are linked
@github-actions
chore(release-next): docs@1.3.0-next.12
d5acb09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

🚀 Storybook has been deployed for branch next

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 97eba6a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mariohamann mariohamann merged commit 15d3c05 into main Jan 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfonseca smfonseca smfonseca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Solid Design System Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mariohamann @smfonseca @paulovareiro29 @DanielHargesheimer