Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🤔 sd-expandable label underline to be removed #1778

Closed
9 tasks
MartaPintoTeixeira opened this issue Jan 14, 2025 · 0 comments
Closed
9 tasks

fix: 🤔 sd-expandable label underline to be removed #1778

MartaPintoTeixeira opened this issue Jan 14, 2025 · 0 comments
Assignees
@paulovareiro29
Labels
🔧 code needs changes in code

Comments

@MartaPintoTeixeira
Copy link
Contributor

Current behavior

While reviewing the sd-expandable I have noticed that in the current version in storybook the label is underlined.

Expected behavior

there should be no underline bellow the labels

Steps to reproduce

check storybook docs and storybook tmplt

Technical Information

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@MartaPintoTeixeira MartaPintoTeixeira added the 🔧 code needs changes in code label Jan 14, 2025
This was referenced Jan 14, 2025
Merged
Open
@MartaPintoTeixeira MartaPintoTeixeira removed their assignment Jan 14, 2025
@paulovareiro29 paulovareiro29 moved this from 📋 Backlog to 👀 In review in Solid Design System Project Board Jan 14, 2025
paulovareiro29 added a commit that referenced this issue Jan 15, 2025
@paulovareiro29 @mariohamann
fix: improve sd-expandable a11y (#1724)
c7bab9d 
<!-- ## Title: Please consider adding the [skip chromatic] flag to the
PR title in case you dont need chromatic testing your changes. -->
## Description:
Closes #1476 and #1778

This PR addresses:
- Adjust sd-expandable spacings according to figma
- Reorder of sd-expandable dom order. (button first so it is targetable
by keyboard first)
- Improvement of the sd-expandable template labels
- Added accessibility hints to sd-expandable

## Definition of Reviewable:
<!-- *PR notes: Irrelevant elements should be removed.* -->
- [x] Documentation is created/updated
- [ ] Migration Guide is created/updated
- [ ] E2E tests (features, a11y, bug fixes) are created/updated
<!-- *If this PR includes a bug fix, an E2E test is necessary to verify
the change. If the fix is purely visual, ensuring it is captured within
our chromatic screenshot tests is sufficient.* -->
- [x] Stories (features, a11y) are created/updated
- [x] relevant tickets are linked

---------

Co-authored-by: Mario Hamann <mario.hamann@virtual-identity.com>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Solid Design System Project Board Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulovareiro29 paulovareiro29

Labels
🔧 code needs changes in code
Projects
Solid Design System Project Board
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulovareiro29 @yoezlem @MartaPintoTeixeira