Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sd-combobox and sd-select #1742

Merged
merged 18 commits into from
Jan 14, 2025
Merged

fix: sd-combobox and sd-select #1742

merged 18 commits into from
Jan 14, 2025

Conversation

DanielHargesheimer
Copy link
Contributor

@DanielHargesheimer DanielHargesheimer commented Dec 17, 2024

Description:

This pr closes:

  • sd-combobox: emit events correctly, set options' initial attributes
  • fix disabled optgroup story
  • add max-options-tag-label attribute to sd-select
  • add --tag-max-width and ellipsis to sd-select
  • Documentation is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: 1d542ad

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 17, 2024

🚀 Storybook has been deployed for branch fix_sd-combobox-sd-select

@DanielHargesheimer DanielHargesheimer linked an issue Dec 17, 2024 that may be closed by this pull request
9 tasks
@mariohamann
Copy link
Contributor

@DanielHargesheimer Could you have a look in the tests? Are they working on your side locally? I had some problems with them in another branch.

@DanielHargesheimer
Copy link
Contributor Author

@mariohamann
I've solved it. The Backspace key event on the tags needed a preventDefault(). The test failed only for the select and only in webkit. I cannot see the difference between select and combobox in this case, so I added it to both components.

smfonseca
smfonseca previously approved these changes Dec 19, 2024
@mariohamann
Copy link
Contributor

@DanielHargesheimer We now fixed our tests on the pipeline due to a big architectural change. Could you please unskip all tests, that are working now?

I skipped them in my branch to be able to merge:

CleanShot 2024-12-19 at 13 34 23@2x

@DanielHargesheimer
Copy link
Contributor Author

@smfonseca, @mariohamann
I cannot reproduce locally the "Verify monorepo" fail.

@smfonseca
Copy link
Collaborator

@smfonseca, @mariohamann I cannot reproduce locally the "Verify monorepo" fail.

I re-ran the failing job and it worked, but the combobox tests locally are still failing.

@paulovareiro29
Copy link
Contributor

I have tested locally and tests are passing

@paulovareiro29
Copy link
Contributor

@smfonseca, @mariohamann I cannot reproduce locally the "Verify monorepo" fail.

It will be fixed on #1758

@mariohamann mariohamann changed the title fix: sd-combobox and sd-select [skip chromatic] fix: sd-combobox and sd-select Jan 9, 2025
@mariohamann
Copy link
Contributor

I just removed [skip chromatic], as we only do this in e. g. in simple docs changes or things that don't do anything in Storybook at all. I merged next to trigger Chromatic.

@mariohamann mariohamann removed their assignment Jan 13, 2025
@mariohamann mariohamann merged commit 125d5f1 into next Jan 14, 2025
12 checks passed
@mariohamann mariohamann deleted the fix/sd-combobox-sd-select branch January 14, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
4 participants