Merge branch 'next' into fix/sd-combobox-sd-select

solid-design-system · Jan 9, 2025 · 1d542ad · 1d542ad
2 parents fee8e6d + 3ff42ed
commit 1d542ad
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 1 deletion.
diff --git a/.changeset/cool-avocados-smash.md b/.changeset/cool-avocados-smash.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/.changeset/ninety-yaks-mix.md b/.changeset/ninety-yaks-mix.md
@@ -0,0 +1,7 @@
+---
+'@solid-design-system/components': patch
+---
+
+Improved sd-divider a11y:
+
+- Implemented aria-orientation attribute 
diff --git a/.changeset/pre.json b/.changeset/pre.json
@@ -16,13 +16,15 @@
     "brown-singers-breathe",
     "chilled-otters-cheat",
     "cold-monkeys-deny",
+    "cool-avocados-smash",
     "cuddly-spies-crash",
     "curvy-worms-sin",
     "eight-otters-protect",
     "fair-laws-heal",
     "fifty-trainers-jump",
     "grumpy-numbers-sort",
     "lovely-tables-divide",
+    "ninety-yaks-mix",
     "pink-peas-visit",
     "quick-yaks-grow",
     "short-tools-prove",

diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md
@@ -1,5 +1,13 @@
 # @solid-design-system/components
 
+## 4.0.0-next.2
+
+### Patch Changes
+
+- Improved sd-divider a11y: _[`#1751`](https://github.com/solid-design-system/solid/pull/1751) [`f0fd5cb`](https://github.com/solid-design-system/solid/commit/f0fd5cb9a61b07cb487455b1da2a374d89ef93ca) [@paulovareiro29](https://github.com/paulovareiro29)_
+
+  - Implemented aria-orientation attribute
+
 ## 4.0.0-next.1
 
 ### Patch Changes

diff --git a/packages/components/package.json b/packages/components/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@solid-design-system/components",
   "description": "Solid Design System: Components",
-  "version": "4.0.0-next.1",
+  "version": "4.0.0-next.2",
   "homepage": "https://solid-design-system.fe.union-investment.de/docs/",
   "author": "Union Investment",
   "license": "MIT",

diff --git a/packages/components/src/components/divider/divider.test.ts b/packages/components/src/components/divider/divider.test.ts
@@ -13,6 +13,7 @@ describe('<sd-divider>', () => {
       const el = await fixture<SdDivider>(html` <sd-divider></sd-divider> `);
 
       expect(el.getAttribute('orientation')).to.equal('horizontal');
+      expect(el.shadowRoot?.querySelector('hr')?.getAttribute('aria-orientation')).to.equal('horizontal');
     });
 
     it('inverted defaults to false', async () => {
@@ -30,6 +31,7 @@ describe('<sd-divider>', () => {
       await elementUpdated(el);
 
       expect(el.getAttribute('orientation')).to.equal('vertical');
+      expect(el.shadowRoot?.querySelector('hr')?.getAttribute('aria-orientation')).to.equal('vertical');
     });
 
     it('inverted is updated', async () => {

diff --git a/packages/components/src/components/divider/divider.ts b/packages/components/src/components/divider/divider.ts
@@ -29,6 +29,7 @@ export default class SdDivider extends SolidElement {
     return html`
       <hr
         part="main"
+        aria-orientation=${this.orientation}
         class=${cx(
           this.inverted ? 'border-primary-400' : 'border-neutral-400',
           this.orientation === 'horizontal' ? 'border-t w-full' : ' border-l h-full'