-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDL-19414: Update datatype for some fields #33
TDL-19414: Update datatype for some fields #33
Conversation
tap_recharge/client.py
Outdated
kwargs['headers']['X-Recharge-Version'] = '2021-11' | ||
kwargs['headers']['X-Recharge-Version'] = '2021-11' | ||
# Products and Shop are not supported in new version: 2021-11 | ||
if path in ['products', 'shop']: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove the shop
from here as it is replaced with a store
in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we will remove shop from here, the Tap will use 2021-11 for getting shop records. We will get 404 Not Found error:
{
"error": "Not Found"
}
@@ -99,7 +99,7 @@ def test_config_provided_request_timeout(self, mock_get, mock_request): | |||
client = RechargeClient(**config) | |||
client.request("GET", "dummy_path") | |||
|
|||
mock_request.assert_called_with('GET', 'https://api.rechargeapps.com/dummy_path', stream=True, timeout=100.0, headers={'X-Recharge-Access-Token': 'dummy_at', 'Accept': 'application/json', 'User-Agent': 'dummy_ua'}) | |||
mock_request.assert_called_with('GET', 'https://api.rechargeapps.com/dummy_path', stream=True, timeout=100.0, headers={'X-Recharge-Access-Token': 'dummy_at', 'Accept': 'application/json', 'X-Recharge-Version': '2021-11', 'User-Agent': 'dummy_ua'}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generalise the headrs in the mock_request.assert_called_with()
to reduce the line length and improve readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes in the test_request_timeout.py
file.
@RushiT0122 That has been covered as part of PR #32 |
* TDL-19329: Update Pagination to cursor based for certain streams (#34) * updated the pagination to cursor-based from page-based * resolved unittests failure * added unittests * updated code and unittests * TDL-19325: Add missing fields (#32) * added missing fields and newly added fields due to api upgrade * resolve unittest failure * added missing fields and updated datatype for some fields * added some missing fields * updated code to use old API verison for onetimes stream * updated unittest as per comments * updated the request timeout unittest * updated the request timeout unittest to use parameterized test data * TDL-19414: Update datatype for some fields (#33) * updated datatype for some fields * resolved unittest failure * updated schema * added code to use old verison for onetimes stream * updated unittests * TDL-19326: Add missing integration tests (#31) * Added missing integration test and missing assertions * Ignored some fields in all_field test * Updated code formatting for start_date test * Updated code comments * Added tap-tester test for interrupted sync * Updated comment Co-authored-by: harshpatel4crest <harsh.patel4@crestdatasys.com> * TDL-19330: Add error logging (#30) * added custom error handling * updated logger.error message * resolve pylint error * updated 429 error class name * updated unittests * updated unittests * resolved comments * updated test cases with parameterized tests * updated config.yml file * updated unittests * updated unittests * TDL-19413: Products stream will not be supported in new version for certain PIMs (#29) * added code to use old API for products strean * updated unittests * updated products schema * updated comment * TDL-19328: Change Shop API (#27) * updated shop endpoint to store * updated shop endpoint to /store * updated readme file and changed shop to store * added a field in store stream * added default_api_version field in shop schema Co-authored-by: Harsh Patel4 <harsh.patel4@CDSYS.LOCAL> * updated the all fields test * reverted the datatype change for a field in discounts stream Co-authored-by: savan-chovatiya <80703490+savan-chovatiya@users.noreply.github.com> Co-authored-by: Harsh Patel4 <harsh.patel4@CDSYS.LOCAL>
Description of change
TDL-19414: Update datatype for some fields
Manual QA steps
Risks
Rollback steps