TDL-19325: Add missing fields #32

hpatel41 · 2022-06-20T08:54:23Z

Description of change

TDL-19325: Add missing fields

Added missing fields and newly added fields due to API Upgrade.

Manual QA steps

Risks

Rollback steps

revert this branch

savan-chovatiya · 2022-06-27T09:43:25Z

tap_recharge/client.py

-            kwargs['headers']['X-Recharge-Version'] = '2021-11'
+        kwargs['headers']['X-Recharge-Version'] = '2021-11'
+        # Products and Shop are not supported in new version: 2021-11
+        if path in ['products', 'shop']:


We can remove shop from here as it is replaced with store in other PR.

We will face 400 error when we run shop on 2021-11, but it will be replaced in the PR #27

dbshah1212 · 2022-06-28T11:30:25Z

tap_recharge/client.py

-        # we will get empty records so adding 'X-Recharge-Version' for 'collections' API call
-        if path == 'collections':
-            kwargs['headers']['X-Recharge-Version'] = '2021-11'
+        kwargs['headers']['X-Recharge-Version'] = '2021-11'


We also removed the above comment, is it intensional?

Yes, now all streams except products and shop will run on 2021-11.

RushiT0122 · 2022-07-13T06:00:32Z

tests/unittests/test_request_timeout.py

@@ -99,7 +99,7 @@ def test_config_provided_request_timeout(self, mock_get, mock_request):
        client = RechargeClient(**config)
        client.request("GET", "dummy_path")

-        mock_request.assert_called_with('GET', 'https://api.rechargeapps.com/dummy_path', stream=True, timeout=100.0, headers={'X-Recharge-Access-Token': 'dummy_at', 'Accept': 'application/json', 'User-Agent': 'dummy_ua'})
+        mock_request.assert_called_with('GET', 'https://api.rechargeapps.com/dummy_path', stream=True, timeout=100.0, headers={'X-Recharge-Access-Token': 'dummy_at', 'Accept': 'application/json', 'X-Recharge-Version': '2021-11', 'User-Agent': 'dummy_ua'})


can we generalise the headers for all the unit tests? it will reduce the line length and improve code readability.

@RushiT0122 Updated the test case to code to generalize params.

RushiT0122

Can we generalise the headers for all the unit tests? It will reduce the line length and improve code readability.

RushiT0122

Changes look good and approving the PR.

Just a suggestion, in unittests like request timeout, where all tests are similar expect the test data. In such cases can we single test implementation and passing timeout value and expectation as test data?

hpatel41 · 2022-07-14T06:51:17Z

Changes look good and approving the PR.

@RushiT0122 Updated the PR as per suggestion. Can you please re-review it.

RushiT0122

In request timeout unittest, test data is declared as a local variable and it will stop execution once it encounters first failure.

Ideally test should run separately for each test data. You can parameterise the unittests to implement it.

hpatel41 · 2022-07-14T13:02:30Z

In request timeout unittest, test data is declared as a local variable and it will stop execution once it encounters first failure.

Ideally test should run separately for each test data. You can parameterise the unittests to implement it.

@RushiT0122 Updated the request timeout test case to use parameterized test case.

RushiT0122

Looks good now!

* TDL-19329: Update Pagination to cursor based for certain streams (#34) * updated the pagination to cursor-based from page-based * resolved unittests failure * added unittests * updated code and unittests * TDL-19325: Add missing fields (#32) * added missing fields and newly added fields due to api upgrade * resolve unittest failure * added missing fields and updated datatype for some fields * added some missing fields * updated code to use old API verison for onetimes stream * updated unittest as per comments * updated the request timeout unittest * updated the request timeout unittest to use parameterized test data * TDL-19414: Update datatype for some fields (#33) * updated datatype for some fields * resolved unittest failure * updated schema * added code to use old verison for onetimes stream * updated unittests * TDL-19326: Add missing integration tests (#31) * Added missing integration test and missing assertions * Ignored some fields in all_field test * Updated code formatting for start_date test * Updated code comments * Added tap-tester test for interrupted sync * Updated comment Co-authored-by: harshpatel4crest <harsh.patel4@crestdatasys.com> * TDL-19330: Add error logging (#30) * added custom error handling * updated logger.error message * resolve pylint error * updated 429 error class name * updated unittests * updated unittests * resolved comments * updated test cases with parameterized tests * updated config.yml file * updated unittests * updated unittests * TDL-19413: Products stream will not be supported in new version for certain PIMs (#29) * added code to use old API for products strean * updated unittests * updated products schema * updated comment * TDL-19328: Change Shop API (#27) * updated shop endpoint to store * updated shop endpoint to /store * updated readme file and changed shop to store * added a field in store stream * added default_api_version field in shop schema Co-authored-by: Harsh Patel4 <harsh.patel4@CDSYS.LOCAL> * updated the all fields test * reverted the datatype change for a field in discounts stream Co-authored-by: savan-chovatiya <80703490+savan-chovatiya@users.noreply.github.com> Co-authored-by: Harsh Patel4 <harsh.patel4@CDSYS.LOCAL>

harshpatel4crest added 2 commits June 20, 2022 14:21

added missing fields and newly added fields due to api upgrade

a8ccf42

resolve unittest failure

3c56a8c

hpatel41 marked this pull request as draft June 20, 2022 09:08

added missing fields and updated datatype for some fields

52518fd

hpatel41 marked this pull request as ready for review June 22, 2022 05:49

savan-chovatiya reviewed Jun 27, 2022

View reviewed changes

dbshah1212 reviewed Jun 28, 2022

View reviewed changes

hpatel41 requested review from dbshah1212 and savan-chovatiya June 29, 2022 05:24

harshpatel4crest added 2 commits June 30, 2022 17:09

added some missing fields

458d284

updated code to use old API verison for onetimes stream

5311171

dbshah1212 approved these changes Jul 5, 2022

View reviewed changes

hpatel41 mentioned this pull request Jul 5, 2022

TDL-19413: Products stream will not be supported in new version for certain PIMs #29

Merged

savan-chovatiya approved these changes Jul 7, 2022

View reviewed changes

hpatel41 requested review from cosimon, kspeer825 and RushiT0122 July 7, 2022 05:31

RushiT0122 reviewed Jul 13, 2022

View reviewed changes

RushiT0122 requested changes Jul 13, 2022

View reviewed changes

updated unittest as per comments

3b2a239

hpatel41 requested a review from RushiT0122 July 13, 2022 12:48

RushiT0122 approved these changes Jul 13, 2022

View reviewed changes

RushiT0122 mentioned this pull request Jul 13, 2022

TDL-19329: Update Pagination to cursor based for certain streams #34

Merged

updated the request timeout unittest

fe71992

hpatel41 requested a review from RushiT0122 July 14, 2022 06:51

updated the request timeout unittest to use parameterized test data

84bc750

RushiT0122 requested changes Jul 14, 2022

View reviewed changes

hpatel41 requested a review from RushiT0122 July 14, 2022 13:02

RushiT0122 approved these changes Jul 15, 2022

View reviewed changes

hpatel41 mentioned this pull request Jul 18, 2022

TDL-19414: Update datatype for some fields #33

Merged

hpatel41 requested a review from luandy64 July 19, 2022 10:50

KrisPersonal approved these changes Jul 19, 2022

View reviewed changes

resolved merge conflicts

81a0b65

hpatel41 merged commit 9c11d80 into crest-master Jul 20, 2022

hpatel41 mentioned this pull request Jul 20, 2022

Crest Work #35

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TDL-19325: Add missing fields #32

TDL-19325: Add missing fields #32

hpatel41 commented Jun 20, 2022

savan-chovatiya Jun 27, 2022

hpatel41 Jun 29, 2022 •

edited

Loading

dbshah1212 Jun 28, 2022

hpatel41 Jun 29, 2022

RushiT0122 Jul 13, 2022

hpatel41 Jul 13, 2022

RushiT0122 left a comment

RushiT0122 left a comment

hpatel41 commented Jul 14, 2022

RushiT0122 left a comment

hpatel41 commented Jul 14, 2022

RushiT0122 left a comment

TDL-19325: Add missing fields #32

TDL-19325: Add missing fields #32

Conversation

hpatel41 commented Jun 20, 2022

Description of change

Manual QA steps

Risks

Rollback steps

savan-chovatiya Jun 27, 2022

Choose a reason for hiding this comment

hpatel41 Jun 29, 2022 • edited Loading

Choose a reason for hiding this comment

dbshah1212 Jun 28, 2022

Choose a reason for hiding this comment

hpatel41 Jun 29, 2022

Choose a reason for hiding this comment

RushiT0122 Jul 13, 2022

Choose a reason for hiding this comment

hpatel41 Jul 13, 2022

Choose a reason for hiding this comment

RushiT0122 left a comment

Choose a reason for hiding this comment

RushiT0122 left a comment

Choose a reason for hiding this comment

hpatel41 commented Jul 14, 2022

RushiT0122 left a comment

Choose a reason for hiding this comment

hpatel41 commented Jul 14, 2022

RushiT0122 left a comment

Choose a reason for hiding this comment

hpatel41 Jun 29, 2022 •

edited

Loading