TDL-19328: Change Shop API #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpatel41
requested review from
dbshah1212,
karanpanchal-crest,
savan-chovatiya and
umangagrawal-crest
tap_recharge/client.py
Outdated
| @@ -187,7 +187,7 @@ def request(self, method, path=None, url=None, **kwargs): # pylint: disable=too- | |||
| # If we did not specify any API Version during API Call, the Recharge will use the default API Version of our store | |||
| # the 'collections' was added as part of API Version: '2021-11', for older API Version, | |||
| # we will get empty records so adding 'X-Recharge-Version' for 'collections' API call | |||
| if path == 'collections': | |||
| if path in ['collections', 'store']: | |||
There was a problem hiding this comment.
Update comment above regarding the reason for store as well.
…-io/tap-recharge into TDL-19328-change-shop-API
hpatel41
commented
Jun 15, 2022
tap_recharge/client.py
Outdated
| @@ -187,7 +187,7 @@ def request(self, method, path=None, url=None, **kwargs): # pylint: disable=too- | |||
| # If we did not specify any API Version during API Call, the Recharge will use the default API Version of our store | |||
| # the 'collections' was added as part of API Version: '2021-11', for older API Version, | |||
| # we will get empty records so adding 'X-Recharge-Version' for 'collections' API call | |||
| if path == 'collections': | |||
| if path in ['collections', 'store']: | |||
There was a problem hiding this comment.
Upgraded API version only for Store as part of this PR. As for some fields, there is schema change in the new version that will result in a Transform error.
savan-chovatiya
approved these changes
Jun 27, 2022
dbshah1212
approved these changes
Jun 28, 2022
RushiT0122
approved these changes
Jul 13, 2022
KrisPersonal
approved these changes
Jul 19, 2022
Merged
RushiT0122
pushed a commit
that referenced
this pull request
Aug 4, 2022
* TDL-19329: Update Pagination to cursor based for certain streams (#34) * updated the pagination to cursor-based from page-based * resolved unittests failure * added unittests * updated code and unittests * TDL-19325: Add missing fields (#32) * added missing fields and newly added fields due to api upgrade * resolve unittest failure * added missing fields and updated datatype for some fields * added some missing fields * updated code to use old API verison for onetimes stream * updated unittest as per comments * updated the request timeout unittest * updated the request timeout unittest to use parameterized test data * TDL-19414: Update datatype for some fields (#33) * updated datatype for some fields * resolved unittest failure * updated schema * added code to use old verison for onetimes stream * updated unittests * TDL-19326: Add missing integration tests (#31) * Added missing integration test and missing assertions * Ignored some fields in all_field test * Updated code formatting for start_date test * Updated code comments * Added tap-tester test for interrupted sync * Updated comment Co-authored-by: harshpatel4crest <harsh.patel4@crestdatasys.com> * TDL-19330: Add error logging (#30) * added custom error handling * updated logger.error message * resolve pylint error * updated 429 error class name * updated unittests * updated unittests * resolved comments * updated test cases with parameterized tests * updated config.yml file * updated unittests * updated unittests * TDL-19413: Products stream will not be supported in new version for certain PIMs (#29) * added code to use old API for products strean * updated unittests * updated products schema * updated comment * TDL-19328: Change Shop API (#27) * updated shop endpoint to store * updated shop endpoint to /store * updated readme file and changed shop to store * added a field in store stream * added default_api_version field in shop schema Co-authored-by: Harsh Patel4 <harsh.patel4@CDSYS.LOCAL> * updated the all fields test * reverted the datatype change for a field in discounts stream Co-authored-by: savan-chovatiya <80703490+savan-chovatiya@users.noreply.github.com> Co-authored-by: Harsh Patel4 <harsh.patel4@CDSYS.LOCAL>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-19328: Change Shop API
/shopto/storeManual QA steps
Risks
Rollback steps