-
-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Material-UI #1676
Add Material-UI #1676
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
Hi! You must add some github topics to your repository: "awesome" and "awesome-list". Also you need to remove "Contributing" title from table of content. You can remove the "Contributing" section from readme at all (but this is not necessary). Just keep contributing.md file at repo. After you solve these problems use awesome-lint to see other issues. I also strongly advise you to read very carefully pull_request_template.md. |
@sergey-pimenov thank you very much for the instructions |
unicorn 🦄 |
awesome-lint still detects several errors:
|
You should review the guidelines about license again |
Some of the items under |
unicorn 🦄 |
@sindresorhus could you please take a look at this one. do let me know if I have done any mistakes. |
All sentences should end in a It would look nicer if the logo was above the header title. I would also center the title.
Applies to the repo description. |
Thank you very much for pointing out my mistakes. I am going to change the requested.
|
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
The repo is using a MIT license, which is not accepted per the guidelines:
|
Hi @sindresorhus, I have completed the tasks you requested. However, I couldn't center the Material-UI title since it requires doesn't support native markup. (I moved logo above the title.) |
This is totally possible. In fact, the readme in this repo does it. |
hi @sindresorhus , |
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
https://github.com/nadunindunil/awesome-material-ui
Material-UI is a successful react component library and it is one of the famous(more than 50k stars) react libraries.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.unicorn
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.