-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Browser Automation #1687
Add Browser Automation #1687
Conversation
unicorn |
You'd better add a Contribute section in readme to encourage people to contribute to your list, refer to https://github.com/jetli/awesome-yew#contribute , your list seems cool besides this, thank you. |
It seems the list fulfills all the requirements except all items being maintained, why is such a big portion of the entries no longer maintained? Per the guidelines:
Even if you move those entries to a separate Markdown file, projects like RoboBrowser (last updated in 2015, and with no useful documentation) or DalekJS (which seems to be completely abandoned and not really finished) could be removed from the list, although that is up to your personal criterion. Overall, great work! As a quick note, you listed PhantomJS as unmaintained, but it was last updated 9 days ago. |
@agucova He's already marked projects like ghost.py with a 🚫 to indicate |
@jetli I think that would be fine if it was a few items (so making a new file was unnecessary), but the guidelines are quite clear in that respect. Perhaps all the unmaintained items could be ordered so they are grouped towards the end of the list? |
@agucova I agree, unmaintained items should be at least grouped to separate section or even separate file. |
@agucova While there are a some unmaintained projects, their web, repository and overall functionality is still useful for people looking for options IMO. Although, I agree some of those may be too old/unfinished projects for this list, I'll try to remove some of the unmaintained items. @agucova PhantomJS is listed as unmainted as despite having recent commits in the repository as the web is down with the notice: |
The following comments have been addressed:
I think I've covered all comments, please let me know if I missed anything or if you don'' agree with these changes 😃 |
Deprecated projects are not awesome. It doesn't benefit anyone to have them in your list. Awesome lists are not historical records. They're not Wikipedia. Awesome lists are meant to be a current overview of the most Awesome and relevant things on a specific topic. People go to your list to find what to use, not what people used to use. Talking specifically about PhantomJS. Honestly, even if it was still actively maintained, it was never awesome (I have a lot of experience dealing with it). |
Use the correct casing for names. |
Seeing as most things are open source, I think you should rather invert |
@sindresorhus I've addressed your comments. However I'll have to insist in keeping some deprecated projects: Despite being deprecated, most of these are still functional tools with a big enough community and people using it, being projects relevant to browser automation and important for a comprehensive list of this topic. About the reasoning behind keeping the deprecated projects:
Hope this makes sense 😊 |
You have your view on how you want your list to be and that's totally fine, but it will not be added here in its existing form. I'm not trying to be difficult. It's simply that I hold every list added to very high standards and I really don't want them to include stuff that are clearly not Awesome, even if it's commonly used. The point of Awesome lists is not to create a historical record. An Awesome list is an opinionated ever-changing view of the most Awesome resources in a community at the current time. |
@sindresorhus I understand your point, however I don't see how a community based project ( |
https://github.com/angrykoala/awesome-browser-automation#readme
Browser automation tools and resources, for web scraping, testing or simply web automation. Currently, only a Selenium-specific list exists related to this.
Some more comments related to this can be found at #1404. This PR is a follow-up of #1513 with the comments addressed as possible.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.unicorn
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.