-
-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Creative Tech Events #1653
Add Creative Tech Events #1653
Conversation
events
and the list `Awesome Creative Tec…
Seems to meet the standards! Needs to be open for 30 days or so I believe but looks OK to me :) |
Does the PR need to be open for 30 days? I thought it was 30 days after the creation of the list? |
Apologies you are quite right, I'd seen the most recent commit on your repo as two days old rather than seeing that the full age of the repo is much older, my mistake! |
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
I ran it through ✖ Linting
README.md:97:52
✖ 97:52 List item description must end with proper punctuation remark-lint:awesome-list-item
1 error I created a PR to your repo to fix this: |
Thanks for fixing @gruhn! I'm pretty sure that's the only thing that stopping this from a merge 🤩 |
It's not. Please read through each guideline. |
60790a6
to
26642b3
Compare
If this list gets its own section, then we should probably move Events in Italy and Events in the Netherlands in the section as well. |
Have reviewed 2 other PR's. Have read through the list again twice. Is there anything else I've missed? |
readme.md
Outdated
@@ -684,3 +685,15 @@ | |||
|
|||
- [Awesome Indexed](https://awesome-indexed.mathew-davies.co.uk) - Search the Awesome dataset. | |||
- [Awesome Search](https://awesomelists.top) - Quick search for Awesome lists. | |||
|
|||
|
|||
## Events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the point in adding a category for only one thing. Add it to Misc first and we can consider moving it into a new category later on if there are more similar lists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the misc category, there's Events in Italy
and Events in the Netherlands
which were added to misc a while ago but since there are now 3 event lists they should now all be under the Events category.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I Agree. I think this would also encourage others to create Awesome Lists of Events!
@sindresorhus if you agree shall I make the change as part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you agree shall I make the change as part of this PR?
That can be a follow-up PR. It's unrelated to adding your list.
Yes:
Instead of writing just |
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
|
@danvoyce I think you still missed something in the guidelines. I recommend reading them again. The problem is equine in nature. |
🦄😬 |
@sindresorhus please let me know your thoughts on the above
unicorn |
Hi @sindresorhus could you please let me know if you are ok with the above? And if there's anything else. Thanks for your patience :) |
That's not correct:
and many more. But you could easily have checked this yourself too.
If the description provided by the associated website is in the correct format and well written sure. If not, it's your job to make it correct, well-written, and "awesome".
👍
This is also not fully done. |
|
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
https://github.com/danvoyce/awesome-creative-tech-events/tree/master
It's quite hard to keep in the loop of all the more niche events / conferences / meetups out there, so hopefully this will help with the slightly niche subject of creating coding / tech.
I've also added a new
Events
category as I felt it didn't fit under any others, and there's starting to be a few other events lists that could also sit under this.PR's reviewed: #1676 #1677
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.unicorn
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.