Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Common Lisp Learning #1681

Merged
merged 2 commits into from
Jan 21, 2020
Merged

Add Common Lisp Learning #1681

merged 2 commits into from
Jan 21, 2020

Conversation

GustavBertram
Copy link
Contributor

@GustavBertram GustavBertram commented Jan 6, 2020

https://github.com/GustavBertram/awesome-common-lisp-learning-list/#readme

This is a list of Common Lisp learning resources, and reviews of those resources.

Reviewed PRs: #1666, #1677, #1653, #1644, #1679

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    • Add Swift
    • Add Software Architecture
    • Update readme.md
    • Add Awesome Swift
    • Add swift
    • Adding Swift
    • Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    • - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • - [Framer](…) - Prototyping interactive UI designs.
    • - [iOS](…) - Resources and tools for iOS development.
    • - [Framer](…)
    • - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • Mobile operating system for Apple phones and tablets.
    • Prototyping interactive UI designs.
    • Resources and tools for iOS development.
    • Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce.
    If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • awesome-swift
    • awesome-web-typography
    • awesome-Swift
    • AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • # Awesome Swift
    • # Awesome Web Typography
    • # awesome-swift
    • # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
  • Has an appropriate license.
    • We strongly recommend the CC0 license, but any Creative Commons license will work.
      • Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0 (replace <user> and <repo> accordingly).
    • A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
    • Place a file named license or LICENSE in the repo root with the license text.
    • Do not add the license name or text to the readme. GitHub already shows the license name at the top of the repo.
    • To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

Also moved the existing Common Lisp libraries link under Common Lisp
@GustavBertram
Copy link
Contributor Author

GustavBertram commented Jan 6, 2020

unicorn

@akegaviar
Copy link
Contributor

You have a dead link for

The ANSI Common Lisp Standard Draft - The last draft version of the ANSI INCITS 226-1994 (previously ANSI X3.226-1994) standard.

✖ Linting

  README.md:52:3
  ✖  52:3  Link to http://cvberry.com/tech_writings/notes/common_lisp_standard_draft.html is dead  remark-lint:no-dead-urls

  1 error

@akegaviar akegaviar mentioned this pull request Jan 10, 2020
@GustavBertram
Copy link
Contributor Author

@akegaviar Nice catch. For some reason linting on my machine doesn't show the same error. Fixed now.

@mgramin
Copy link
Contributor

mgramin commented Jan 13, 2020

awesome-lint on my machine found some trailing slashes and wrong marker

  ×   45:5   Remove trailing slash (http://articulate-lisp.com)    trailing-slash
  ×   50:97  Emphasis should use * as a marker                     emphasis-marker
  ×   69:3   Remove trailing slash (https://letoverlambda.com)     trailing-slash
  ×   77:3   Remove trailing slash (http://landoflisp.com)         trailing-slash
  ×   93:88  Remove trailing slash (http://freenode.net)           trailing-slash
  ×  113:3   Remove trailing slash (https://clisp.sourceforge.io)  trailing-slash
  ×  115:3   Remove trailing slash (https://ccl.clozure.com)       trailing-slash
  ×  123:3   Remove trailing slash (http://www.sbcl.org)           trailing-slash

  8 errors

@mgramin mgramin mentioned this pull request Jan 13, 2020
@GustavBertram
Copy link
Contributor Author

@mgramin Thanks, fixed. Again, not showing up on my machine. Weird!

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@GustavBertram GustavBertram changed the title Add Common Lisp Learning List Add Common Lisp Learning Jan 19, 2020
@GustavBertram
Copy link
Contributor Author

@sindresorhus Updated to address your two issues.

@sindresorhus sindresorhus merged commit f0a0ecd into sindresorhus:master Jan 21, 2020
@sindresorhus
Copy link
Owner

DejanPerovic pushed a commit to DejanPerovic/awesome that referenced this pull request Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants