Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ukrainian locale #312

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Added Ukrainian locale #312

merged 1 commit into from
Nov 10, 2023

Conversation

Andygol
Copy link
Contributor

@Andygol Andygol commented Nov 9, 2023

I bring to your attention PR, which adds Ukrainian locale.

@adamrusted
Copy link
Member

Thanks so much for your contribution @Andygol - and don't worry about the tests failing. We'll get to looking at that, looks like an issue on our end. Would you be so kind as to contribute the locale to the beta website repo too, over at https://github.com/mondeja/simple-icons-website-rs?

@Andygol
Copy link
Contributor Author

Andygol commented Nov 9, 2023

image I've tested locally and all looks good.

Would you be so kind as to contribute the locale to the beta website repo too, over at https://github.com/mondeja/simple-icons-website-rs?

Sure, I'll take a look.

@Andygol
Copy link
Contributor Author

Andygol commented Nov 9, 2023

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you! 🇺🇦

@mondeja mondeja merged commit 6f742e8 into simple-icons:master Nov 10, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants