MNT Require caret version of frameworktest #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/1.10/travis-frameworktest
branch
from
f176081
to
803e962
Compare
This was referenced Mar 23, 2022
|
The related PR has been merged but the build is still failing. |
|
@maxime-rainville I'm not sure what's causing this error. I've tried running the same code via github actions instead - https://github.com/emteknetnz/silverstripe-admin/runs/5779812778?check_suite_focus=true - and it passes there This broken behat test is unrelated to this PR though, and this PR is blocking #1295 from being merged. Are you happy to merge as is? |
maxime-rainville
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://app.travis-ci.com/github/silverstripe/silverstripe-admin/jobs/563165315#L421
Travis failures are related to email, which I think will be fixed separately by silverstripe/silverstripe-behat-extension#210
Parent issue