Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Add update JS deps workflow #1138

Merged
merged 1 commit into from
Mar 30, 2022
Merged

MNT Add update JS deps workflow #1138

merged 1 commit into from
Mar 30, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz
Copy link
Member Author

emteknetnz commented Mar 23, 2022 •
edited
Loading

Unit test failure is existing and attempted to fix on silverstripe/silverstripe-admin#1296

maxime-rainville
maxime-rainville approved these changes Mar 30, 2022
View reviewed changes
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure the failures is not related to this PR. We got too many things in flight right now. Let's get it merge and sort out the builds afterwards.

@maxime-rainville maxime-rainville merged commit cd0deae into silverstripe:5 Mar 30, 2022
@maxime-rainville maxime-rainville deleted the pulls/5/update-js-deps branch March 30, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @maxime-rainville