FIX Define admin_email #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue https://github.com/silverstripeltd/product-issues/issues/526
I'm guessing this is going to fix this failure https://app.travis-ci.com/github/silverstripe/silverstripe-userforms/jobs/563941543#L1510
There was recently a couple of framework commits that altered how the the default admin_email is handled, which I think may have impacted this particular behat test in a CI context. I wasn't able to replicate this issue on my local, even without an explicitly admin_email defined, though possible the Director::host() fallback is just finding a sensible default, while presumably CI is not. I'm hoping that explicitly defining the admin_email will fix this issue in CI